Stream: git-wasmtime

Topic: wasmtime / PR #14869 Handle empty names in the component ...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 21:59):

jrandolf opened PR #14869 from jrandolf:c-api-null-name to bytecodealliance:main:

Several functions in the component C API passed a name pointer and length straight to std::slice::from_raw_parts. That's UB for a null pointer even when the length is zero, which is exactly what the C++ API passes for a default std::string_view, and debug builds abort with "unsafe precondition(s) violated". There were 10 of these: the component and instance type lookups, the five linker add_* functions, and the two get_export_index functions. They now use the existing slice_from_raw_parts helper, like the rest of the C API.

The new tests only crash without the fix in a debug build, which is what CI uses.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:01):

jrandolf has marked PR #14869 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:01):

jrandolf removed the review request for wasmtime-core-reviewers from PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:01):

jrandolf requested wasmtime-core-reviewers for a review on PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:01):

jrandolf requested dicej for a review on PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 01:09):

github-actions[bot] added the label wasmtime:c-api on PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 17:05):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 17:05):

:speech_balloon: alexcrichton created PR review comment:

Can this test use the C++ API rather than the C API, at least for the bulk of the skeleton?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 17:05):

alexcrichton removed the review request for dicej from PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 18:58):

:memo: jrandolf submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 18:58):

:speech_balloon: jrandolf created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 19:01):

jrandolf updated PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 19:06):

jrandolf requested alexcrichton for a review on PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 19:58):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 19:58):

alexcrichton added PR #14869 Handle empty names in the component C API to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 20:40):

:check: alexcrichton merged PR #14869.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 20:40):

alexcrichton removed PR #14869 Handle empty names in the component C API from the merge queue.

Last updated: Oct 31 2026 at 23:03 UTC