Stream: git-wasmtime

Topic: wasmtime / PR #14866 Keep the full implements version whe...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 21:59):

jrandolf opened PR #14866 from jrandolf:implements-canonical-version to bytecodealliance:main:

With canonical names enabled, (implements "a:b/c@1") (version-suffix ".2.3") was recorded as just a:b/c@1. So ComponentExtern::implements reported a truncated name, and is_implements didn't match any version of the interface, which made bindgen!'s named_imports and the WASI add_named_to_linker silently skip such imports. This records the full a:b/c@1.2.3, using wasmparser's full_implements().

Root import names had the same problem: an import of a:b/c@1 with suffix .2.3 was looked up in the Linker as a:b/c@1, which never matches a host definition like a:b/c@1.2.3. Imports now use the full name too. Lookups inside the component still use the short canonical name.

Exports with a version suffix still use the short name (get_export("a:b/c@1.2.3") doesn't find them), and so do interface-named exports inside instance and component types. Fixing those is a larger change, so I left them for a follow-up.

Closes #14854

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:04):

jrandolf has marked PR #14866 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:04):

jrandolf removed the review request for wasmtime-core-reviewers from PR #14866.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:04):

jrandolf requested dicej for a review on PR #14866.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 22:04):

jrandolf requested wasmtime-core-reviewers for a review on PR #14866.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 01:09):

github-actions[bot] added the label wasmtime:api on PR #14866.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 16:52):

:memo: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 16:52):

:speech_balloon: alexcrichton created PR review comment:

I don't think that this is quite right -- the intention is that the exact name of the import is what's keyed on and what's in the map. Wasmtime doesn't intend to just erase the version-suffix, but rather in the future the goal is to simplify the maps in Wasmtime to not have any semver matching at all (ideally) and purely rely on the un-suffixed name.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 16:52):

alexcrichton removed the review request for dicej from PR #14866.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 19:34):

jrandolf updated PR #14866.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 20:07):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 20:07):

alexcrichton added PR #14866 Keep the full implements version when canonical names are enabled to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 20:42):

:check: alexcrichton merged PR #14866.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 20:42):

alexcrichton removed PR #14866 Keep the full implements version when canonical names are enabled from the merge queue.

Last updated: Oct 31 2026 at 23:03 UTC