Stream: git-wasmtime

Topic: wasmtime / PR #1486 wasmtime: Pass around more contexts i...

Wasmtime GitHub notifications bot (Apr 08 2020 at 18:29):

alexcrichton opened PR #1486 from refactor-translation to master:

This commit refactors some wasmtime internals to pass around more
context-style structures rather than individual fields of each
structure. The intention here is to make the addition of fields to a
structure easier to plumb throughout the internals of wasmtime.
Currently you need to edit lots of functions to pass lots of parameters,
but ideally after this you'll only need to edit one or two struct fields
and then relevant locations have access to the information already.

Updates in this commit are:

• debug_info configuration is now folded into Tunables. Additionally
  a wasmtime::Config now holds a Tunables directly and is passed
  into an internal Compiler. Eventually this should allow for direct
  configuration of the Tunables attributes from the wasmtime API,
  but no new configuration is exposed at this time.

• ModuleTranslation is now passed around as a whole rather than
  passing individual components to allow access to all the fields,
  including Tunables.

This was motivated by investigating what it would take to optionally
allow loops and such to get interrupted, but that sort of codegen
setting was currently relatively difficult to plumb all the way through
and now it's hoped to be largely just an addition to Tunables.

Wasmtime GitHub notifications bot (Apr 08 2020 at 18:40):

alexcrichton updated PR #1486 from refactor-translation to master:

This commit refactors some wasmtime internals to pass around more
context-style structures rather than individual fields of each
structure. The intention here is to make the addition of fields to a
structure easier to plumb throughout the internals of wasmtime.
Currently you need to edit lots of functions to pass lots of parameters,
but ideally after this you'll only need to edit one or two struct fields
and then relevant locations have access to the information already.

Updates in this commit are:

• debug_info configuration is now folded into Tunables. Additionally
  a wasmtime::Config now holds a Tunables directly and is passed
  into an internal Compiler. Eventually this should allow for direct
  configuration of the Tunables attributes from the wasmtime API,
  but no new configuration is exposed at this time.

• ModuleTranslation is now passed around as a whole rather than
  passing individual components to allow access to all the fields,
  including Tunables.

This was motivated by investigating what it would take to optionally
allow loops and such to get interrupted, but that sort of codegen
setting was currently relatively difficult to plumb all the way through
and now it's hoped to be largely just an addition to Tunables.

Wasmtime GitHub notifications bot (Apr 08 2020 at 20:19):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Apr 08 2020 at 20:22):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Apr 08 2020 at 20:22):

abrown created PR Review Comment:

I'm assuming this was used by a PrimaryMap in compile but I didn't look closely enough; just checking that it is used somewhere...

Wasmtime GitHub notifications bot (Apr 09 2020 at 00:02):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Apr 09 2020 at 00:02):

alexcrichton created PR Review Comment:

Ah yeah the Hash here is used as a hash key for cached module compilations, so it is indeed used :)

Wasmtime GitHub notifications bot (Apr 09 2020 at 00:02):

alexcrichton merged PR #1486.

Last updated: Dec 23 2024 at 12:05 UTC