alexcrichton removed the review request for wasmtime-core-reviewers from PR #14846.
alexcrichton opened PR #14846 from alexcrichton:no-panic-invalid-adapter to bytecodealliance:main:
It's possible for adapter modules generated to be invalid when the embedder specifically disables wasm features like multi-memory or reference types. Instead of panicking the compilation process in such a situation this instead returns an error with extra context at least indicating it was from the adapter.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested pchickey for a review on PR #14846.
alexcrichton requested wasmtime-core-reviewers for a review on PR #14846.
:thumbs_up: pchickey submitted PR review.
alexcrichton added PR #14846 Don't panic on invalid adapter modules to the merge queue.
:check: alexcrichton merged PR #14846.
alexcrichton removed PR #14846 Don't panic on invalid adapter modules from the merge queue.
Last updated: Oct 31 2026 at 23:03 UTC