Stream: git-wasmtime

Topic: wasmtime / PR #14842 Fix record field count check in the ...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:18):

jrandolf opened PR #14842 from jrandolf:wast-record-field-count to bytecodealliance:main:

The record case in the wast harness compared e.len() != e.len(), which is always false, so an assert_return with fewer (or more) record fields than the actual value passed as long as the fields that were zipped together matched. This compares against the actual record and includes both counts in the error, and adds a test of the harness itself.

I came across this while looking at map support, but it's not map specific.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:29):

jrandolf has marked PR #14842 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:29):

jrandolf removed the review request for wasmtime-core-reviewers from PR #14842.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:29):

jrandolf requested dicej for a review on PR #14842.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:29):

jrandolf requested wasmtime-core-reviewers for a review on PR #14842.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 20:38):

:memo: alexcrichton submitted PR review:

Thanks, but it's ok to skip the test here, it's a bit overkill to be so specific as to look for byte patterns in what are mostly debugging error messages

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 20:44):

:cross_mark: jrandolf closed without merge PR #14842.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 20:44):

jrandolf commented on PR #14842:

Then I'll close this for now.

Last updated: Oct 31 2026 at 23:03 UTC