Stream: git-wasmtime

Topic: wasmtime / PR #14839 Clarify map docs and add `Type::unwr...

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:18):

jrandolf opened PR #14839 from jrandolf:map-docs-api to bytecodealliance:main:

A few small things found while looking at map<K, V>:

• The Val::Map docs said duplicate keys follow "last value wins" semantics, but Val::Map keeps every entry in order, duplicates included (only lifting into a typed HashMap deduplicates). This documents that, along with how map equality behaves.
• Adds Type::unwrap_map to match the other unwrap_* accessors.
• Mentions the :map: emoji and the default in the config and CLI docs, like the neighboring options.
  

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:28):

jrandolf has marked PR #14839 as ready for review.

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:28):

jrandolf removed the review request for wasmtime-core-reviewers from PR #14839.

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:28):

jrandolf requested wasmtime-core-reviewers for a review on PR #14839.

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:28):

jrandolf requested pchickey for a review on PR #14839.

Wasmtime GitHub notifications bot (Oct 19 2026 at 21:44):

github-actions[bot] added the label wasmtime:api on PR #14839.

Wasmtime GitHub notifications bot (Oct 19 2026 at 21:44):

github-actions[bot] added the label wasmtime:config on PR #14839.

Wasmtime GitHub notifications bot (Oct 19 2026 at 22:45):

github-actions[bot] commented on PR #14839:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Oct 19 2026 at 23:21):

:thumbs_up: pchickey submitted PR review.

Wasmtime GitHub notifications bot (Oct 19 2026 at 23:22):

pchickey added PR #14839 Clarify map docs and add Type::unwrap_map to the merge queue

Wasmtime GitHub notifications bot (Oct 19 2026 at 23:46):

:check: pchickey merged PR #14839.

Wasmtime GitHub notifications bot (Oct 19 2026 at 23:46):

pchickey removed PR #14839 Clarify map docs and add Type::unwrap_map from the merge queue

Last updated: Oct 31 2026 at 23:03 UTC