Stream: git-wasmtime

Topic: wasmtime / PR #14838 Pass anonymous maps to exported func...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:18):

jrandolf opened PR #14838 from jrandolf:bindgen-map-param-ref to bytecodealliance:main:

For an exported function taking an anonymous map<K, V>, bindgen! generated a by-value HashMap of borrowed keys and values (e.g. HashMap<&str, &[String]>), so callers holding a HashMap<String, Vec<String>> had to build a second map of references to make a call. This mirrors how lists are handled instead: in borrowed positions the map is taken by reference, and with Ownership::Owning its keys and values are owned. Named map types already generated &Named.

This changes generated signatures, see #14831. It's based on #14834; only the last commit is new.

Closes #14831

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:26):

jrandolf has marked PR #14838 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:26):

jrandolf removed the review request for wasmtime-core-reviewers from PR #14838.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:26):

jrandolf requested dicej for a review on PR #14838.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 19:26):

jrandolf requested wasmtime-core-reviewers for a review on PR #14838.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 16:35):

:thumbs_up: alexcrichton submitted PR review:

(holding off on merge queue unil prereq is merged)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 16:35):

alexcrichton removed the review request for dicej from PR #14838.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 18:53):

jrandolf updated PR #14838.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 21:12):

jrandolf updated PR #14838.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 21:32):

jrandolf commented on PR #14838:

@alexcrichton This one is ready for merge.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 21:41):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 21:41):

alexcrichton added PR #14838 Pass anonymous maps to exported functions by reference in bindgen! to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 22:25):

:check: alexcrichton merged PR #14838.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 22:25):

alexcrichton removed PR #14838 Pass anonymous maps to exported functions by reference in bindgen! from the merge queue

Last updated: Oct 31 2026 at 23:03 UTC