Stream: git-wasmtime

Topic: wasmtime / PR #14834 Add tests for map<K, V> in bindgen! ...

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:18):

jrandolf opened PR #14834 from jrandolf:map-codegen-tests to bytecodealliance:main:

This adds a map.wit codegen test, which gets compiled with each of the bindgen! option variants and snapshotted in tests/expanded, plus runtime tests that use HashMap through TypedFunc and a typed host function. Neither path had any coverage outside of fuzzing.

The snapshots intentionally record the current output (including std::collections::HashMap and the by-value map parameters), so the follow-up PRs for those show up as snapshot diffs.

Closes #14813

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:23):

jrandolf has marked PR #14834 as ready for review.

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:23):

jrandolf removed the review request for wasmtime-core-reviewers from PR #14834.

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:23):

jrandolf requested dicej for a review on PR #14834.

Wasmtime GitHub notifications bot (Oct 19 2026 at 19:23):

jrandolf requested wasmtime-core-reviewers for a review on PR #14834.

Wasmtime GitHub notifications bot (Oct 20 2026 at 16:29):

:memo: alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2026 at 16:29):

:speech_balloon: alexcrichton created PR review comment:

Could this and the above test be folded together? Not much of a reason to keep them separate

Wasmtime GitHub notifications bot (Oct 20 2026 at 16:29):

:speech_balloon: alexcrichton created PR review comment:

Could this actually be added as a *.wast test instead? That'll I suspect require adding map support to the wasmtime-wast crate, but I think tests like this would be best supported elsewhere rather than in the func.rs suite

Wasmtime GitHub notifications bot (Oct 20 2026 at 18:53):

jrandolf updated PR #14834.

Wasmtime GitHub notifications bot (Oct 20 2026 at 18:58):

:memo: jrandolf submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2026 at 18:58):

:speech_balloon: jrandolf created PR review comment:

Makes sense. The wast tooling doesn't support map values yet (neither wast nor wasmtime-wast), so I've dropped this test here and I'll add a .wast version together with map support there.

Wasmtime GitHub notifications bot (Oct 20 2026 at 18:58):

:memo: jrandolf submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2026 at 18:58):

:speech_balloon: jrandolf created PR review comment:

Done

Wasmtime GitHub notifications bot (Oct 20 2026 at 19:00):

:speech_balloon: jrandolf edited PR review comment.

Wasmtime GitHub notifications bot (Oct 20 2026 at 19:04):

jrandolf requested alexcrichton for a review on PR #14834.

Wasmtime GitHub notifications bot (Oct 20 2026 at 19:57):

:thumbs_up: alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2026 at 19:57):

alexcrichton added PR #14834 Add tests for map<K, V> in bindgen! and the typed API to the merge queue.

Wasmtime GitHub notifications bot (Oct 20 2026 at 20:19):

:check: alexcrichton merged PR #14834.

Wasmtime GitHub notifications bot (Oct 20 2026 at 20:19):

alexcrichton removed PR #14834 Add tests for map<K, V> in bindgen! and the typed API from the merge queue.

Wasmtime GitHub notifications bot (Oct 20 2026 at 22:47):

:memo: jrandolf submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2026 at 22:47):

:speech_balloon: jrandolf created PR review comment:

Added in #14890, along with map support in wast (bytecodealliance/wasm-tools#2784).

Last updated: Oct 31 2026 at 23:03 UTC