alexcrichton removed the review request for wasmtime-core-reviewers from PR #14827.
alexcrichton requested wasmtime-core-reviewers for a review on PR #14827.
alexcrichton opened PR #14827 from alexcrichton:pr to bytecodealliance:main:
This commit fixes an issue where a
StreamAnycan be used to re-type a future or stream in a manner that can cause a panic within Wasmtime in certain host situations. The fix here is to unconditionally perform a type-check when lowering a future or stream into a guest. This is already required for{Stream,Future}Any, and it's additionally required in this issue when theTinStreamReader<T>contains aStreamAny, for example. This technically makes the static type-check ofStreamReader<u32>redundant, but it seems best to fully close this hole since #14733 was not a complete fix for this class of issues.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested dicej for a review on PR #14827.
:thumbs_up: pchickey submitted PR review.
alexcrichton added PR #14827 Centralize type-checks of futures/streams to the merge queue.
:check: alexcrichton merged PR #14827.
alexcrichton removed PR #14827 Centralize type-checks of futures/streams from the merge queue.
Last updated: Oct 31 2026 at 23:03 UTC