Stream: git-wasmtime

Topic: wasmtime / PR #1481 Add Go as an embedding to the book

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 17:59):

alexcrichton opened PR #1481 from go-bindings to master:

Also take this time to list out all embeddings in the README of wasmtime
itself.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 19:55):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 19:55):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 19:55):

sunfishcode created PR Review Comment:

I suggest dropping the "currently" and "outside of wasmtime" parts of the phrase. It's in its own repository and there aren't any obvious reasons we'd want to change that.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 19:55):

sunfishcode created PR Review Comment:

This is examples-c-wasi.md so if we don't have a C example yet, we should just say so :-).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 19:55):

sunfishcode created PR Review Comment:

Would it make sense to rename embed-rust.html to lang-rust.html and embed.md to lang.md, and remove embed-c.md, so that we don't have some languages using embed-* and others using lang-*?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 21:43):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 21:43):

alexcrichton created PR Review Comment:

Oh in this case this is actually the source code for the wasm module, the C code to run it is pasted below

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 21:43):

alexcrichton updated PR #1481 from go-bindings to master:

Also take this time to list out all embeddings in the README of wasmtime
itself.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 22:57):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 22:57):

sunfishcode created PR Review Comment:

This should point to lang-rust.html now.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 22:57):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 08 2020 at 16:03):

alexcrichton updated PR #1481 from go-bindings to master:

Also take this time to list out all embeddings in the README of wasmtime
itself.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 08 2020 at 16:03):

alexcrichton merged PR #1481.

Last updated: Dec 23 2024 at 12:05 UTC