jrandolf opened PR #14801 from jrandolf:cm-map-default to bytecodealliance:main:
WASI 0.3.1 adopted the
map<K, V>type, which means runtimes need to support it to be compatible with WASI 0.3.1 and later (see ComponentModelFeatures.md).docs/stability-wasm-proposals.mdalready lists every criterion as met formap, so this flips the default and moves it into the on-by-default table.Without this a component that uses
mapfails to load unless-W component-model-mapis passed.
jrandolf requested dicej for a review on PR #14801.
jrandolf requested wasmtime-core-reviewers for a review on PR #14801.
jrandolf requested fitzgen for a review on PR #14801.
jrandolf requested wasmtime-default-reviewers for a review on PR #14801.
github-actions[bot] added the label wasmtime:api on PR #14801.
github-actions[bot] added the label wasmtime:config on PR #14801.
github-actions[bot] added the label wasmtime:docs on PR #14801.
github-actions[bot] commented on PR #14801:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
:thumbs_up: dicej submitted PR review.
:repeat: alexcrichton submitted PR review:
I don't believe that
map<K, V>is suitable to enable just yet. I've filed a few issues:
- https://github.com/bytecodealliance/wasmtime/issues/14813
- https://github.com/bytecodealliance/wasmtime/issues/14812
- https://github.com/bytecodealliance/wasmtime/issues/14811
- https://github.com/bytecodealliance/wasmtime/issues/14810
These are the most serious issues I found in a review locally, but tehre's a litany of possible issues with
bindgen!as well in terms of no-std compat, the limitations placed on the current impls, the lack of support for types in the current impls (e.g. noBTreeMap, no "just give me the list", etc).Overall I do not personally feel that this is ready to just turn it on.
jrandolf commented on PR #14801:
Thanks for the review. Let me do some investigation and come back to you. I'll open some stabilization PRs.
jrandolf edited a comment on PR #14801:
Thanks for the review. Let me do some investigation and come back to you. I'll open some PRs toward stabilization
jrandolf updated PR #14801.
fitzgen removed the review request for fitzgen from PR #14801.
jrandolf updated PR #14801.
Last updated: Oct 31 2026 at 23:03 UTC