Stream: git-wasmtime

Topic: wasmtime / PR #14784 wasi-http: send bodies of GET, HEAD,...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 17:38):

xia-chao opened PR #14784 from xia-chao:wasi-http-get-body-framing to bytecodealliance:main:

An outgoing GET, HEAD or CONNECT request dropped its body. The host now adds transfer-encoding: chunked, which hyper requires for those methods.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 17:38):

xia-chao requested rvolosatovs for a review on PR #14784.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 17:38):

xia-chao requested wasmtime-wasi-reviewers for a review on PR #14784.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 17:38):

xia-chao requested wasmtime-core-reviewers for a review on PR #14784.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 17:38):

xia-chao requested pchickey for a review on PR #14784.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 18:39):

:memo: rvolosatovs submitted PR review:

I find it quite surprising for GET/HEAD/CONNECT requests to carry a body, in fact I would expect the (default) wasi-http implementation to explicitly reject such requests.

Could you share a bit more context as to why this would be a desirable feature?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 18:49):

xia-chao commented on PR #14784:

it's not that get bodies are desirable. today the body is accepted, finish returns ok, and the origin receives none,that's the bug. rejecting is fine with us, but it would also fail ge ts that create a body and write nothing.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 18:53):

xia-chao commented on PR #14784:

If the preference is to reject the request, which error code should the handle function return?
And if you’d rather reject it, then you should be the one to handle this task.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 18:57):

xia-chao edited a comment on PR #14784:

If the preference is to reject the request, which error code should the handle function return?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2026 at 18:54):

rvolosatovs commented on PR #14784:

If the preference is to reject the request, which error code should the handle function return?

HTTP-protocol-error perhaps?

https://github.com/WebAssembly/WASI/blob/463701e0f6c575a5d24ae31c2ec1e0ebf09d28e1/proposals/http/wit/types.wit#L71

Otherwise, we could also just use internal-error with a message I think https://github.com/WebAssembly/WASI/blob/463701e0f6c575a5d24ae31c2ec1e0ebf09d28e1/proposals/http/wit/types.wit#L79

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 11:55):

xia-chao updated PR #14784.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 12:03):

xia-chao commented on PR #14784:

Tried the “HTTP protocol error” thing, but with that “/get with body” also fails, since the host can’t really tell whether a body has content. Keep sending for now. Also added a case where a GET body gets created but never written to.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2026 at 12:13):

xia-chao commented on PR #14784:

So I don't recommend rejecting the request, do you think?

Last updated: Oct 31 2026 at 23:03 UTC