xia-chao opened PR #14779 from xia-chao:serve-coredump-file to bytecodealliance:main:
run writes the coredump with -D coredump=<path>; serve previously only printed it to stderr.
Now, for the same option, serve writes it too.
xia-chao requested dicej for a review on PR #14779.
xia-chao requested wasmtime-core-reviewers for a review on PR #14779.
:memo: alexcrichton submitted PR review:
It looks like this is all a dupe of the handling code in
run.rsI think -- would it be possible to perhaps deduplicate that to a shared common implementation?
xia-chao updated PR #14779.
xia-chao commented on PR #14779:
Not entirely, because this is a scam for handling code in run.rs.
Thank you, it's already gone heavy!
xia-chao deleted a comment on PR #14779:
Not entirely, because this is a scam for handling code in run.rs.
Thank you, it's already gone heavy!
xia-chao commented on PR #14779:
not entirely. the write was a copy so I shared it. the checks aren't the same.
:thumbs_up: alexcrichton submitted PR review.
alexcrichton added PR #14779 write the coredump to the configured path to the merge queue.
:check: alexcrichton merged PR #14779.
alexcrichton removed PR #14779 write the coredump to the configured path from the merge queue.
Last updated: Oct 31 2026 at 23:03 UTC