Stream: git-wasmtime

Topic: wasmtime / PR #14772 Implement PIC for s390x

Wasmtime GitHub notifications bot (Oct 15 2026 at 13:41):

theotherjimmy opened PR #14772 from theotherjimmy:s390x-pic to bytecodealliance:main:

This uses the R_390_GOTENT relocation instead of the inline relocations previously emitted.

This is the same issue reported as #2907 but for s390x
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 15 2026 at 13:47):

theotherjimmy updated PR #14772.

Wasmtime GitHub notifications bot (Oct 15 2026 at 13:50):

theotherjimmy updated PR #14772.

Wasmtime GitHub notifications bot (Oct 15 2026 at 16:49):

github-actions[bot] added the label isle on PR #14772.

Wasmtime GitHub notifications bot (Oct 15 2026 at 16:49):

github-actions[bot] added the label cranelift on PR #14772.

Wasmtime GitHub notifications bot (Oct 15 2026 at 16:49):

github-actions[bot] added the label cranelift:module on PR #14772.

Wasmtime GitHub notifications bot (Oct 15 2026 at 16:50):

github-actions[bot] commented on PR #14772:

Subscribe to Label Action

cc @avanhatt, @cfallin, @fitzgen, @mmcloughlin

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:module", "isle"

Thus the following users have been cc'd because of the following labels:

• avanhatt: isle
• cfallin: isle
• fitzgen: isle
• mmcloughlin: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 16 2026 at 13:56):

theotherjimmy updated PR #14772.

Wasmtime GitHub notifications bot (Oct 29 2026 at 13:18):

theotherjimmy has marked PR #14772 as ready for review.

Wasmtime GitHub notifications bot (Oct 29 2026 at 13:19):

theotherjimmy requested wasmtime-compiler-s390x-reviewers for a review on PR #14772.

Wasmtime GitHub notifications bot (Oct 29 2026 at 13:19):

theotherjimmy removed the review request for wasmtime-compiler-reviewers from PR #14772.

Wasmtime GitHub notifications bot (Oct 29 2026 at 13:19):

theotherjimmy requested cfallin for a review on PR #14772.

Wasmtime GitHub notifications bot (Oct 29 2026 at 13:19):

theotherjimmy requested wasmtime-compiler-reviewers for a review on PR #14772.

Wasmtime GitHub notifications bot (Oct 29 2026 at 14:28):

:memo: uweigand submitted PR review.

Wasmtime GitHub notifications bot (Oct 29 2026 at 14:28):

:speech_balloon: uweigand created PR review comment:

We can use LGRL rd, sym@GOTENT, saving one instruction. Also, I do not think it makes sense to support an offset with this relocation - it would be preferable to have no offset here (just like TlsGd), and perform any offset addition that might be necessary at the ISLE level.

Wasmtime GitHub notifications bot (Oct 29 2026 at 14:28):

:speech_balloon: uweigand created PR review comment:

We probably want to use (if-let false (is_pic)) here then.

Wasmtime GitHub notifications bot (Oct 29 2026 at 14:28):

:speech_balloon: uweigand created PR review comment:

In the case where we have a GOT, we might want to move TLS descriptors into the GOT as well (as is done by other static compilers). Otherwise, we can get the same problem with relocations on the text section ...

Wasmtime GitHub notifications bot (Oct 29 2026 at 14:28):

:speech_balloon: uweigand created PR review comment:

Static compilers would use the PLT here. The only difference is that going via GOT will disable lazy binding, but that may not really be relevant here ... Might still be interesting to see if brasl func@PLT would also work.

Wasmtime GitHub notifications bot (Oct 29 2026 at 14:28):

:speech_balloon: uweigand created PR review comment:

I think if we just hard-code 0 instead of offset here, common ISLE logic will already handle offsets elsewhere (via regular addition). But that needs to be verified.

Wasmtime GitHub notifications bot (Oct 29 2026 at 15:48):

:thumbs_up: cfallin submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Oct 29 2026 at 15:48):

cfallin added PR #14772 Implement PIC for s390x to the merge queue.

Wasmtime GitHub notifications bot (Oct 29 2026 at 16:07):

uweigand commented on PR #14772:

Hi @cfallin I don't think this is ready to merge just yet, see the comments above ...

Wasmtime GitHub notifications bot (Oct 29 2026 at 16:16):

cfallin removed PR #14772 Implement PIC for s390x from the merge queue.

Wasmtime GitHub notifications bot (Oct 29 2026 at 16:16):

cfallin commented on PR #14772:

Ah, sorry about that, our reviews raced. Removed from queue and will wait for resolution on the above.

Last updated: Oct 31 2026 at 23:03 UTC