alexcrichton opened PR #14755 from alexcrichton:fix-oom-resource to bytecodealliance:main:
This commit fixes an issue when OOM happens while inserting a host resource into the store. When this happens it could leave the preexisting tables in a slightly erroneous state where two that are intended to be kept in sync are no longer in sync, meaning that further use of the store, such as inserting more resources, might panic. The fix here is to handle an error and roll-back an insertion halfway done.
This additionally cleans up the tests a bit, removing a duplicate test and removing an unneeded component.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #14755.
alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #14755.
alexcrichton requested wasmtime-core-reviewers for a review on PR #14755.
github-actions[bot] added the label fuzzing on PR #14755.
github-actions[bot] added the label wasmtime:api on PR #14755.
github-actions[bot] commented on PR #14755:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
:thumbs_up: fitzgen submitted PR review.
fitzgen added PR #14755 Fix a possible panic-after-oom with host resources to the merge queue.
github-merge-queue[bot] removed PR #14755 Fix a possible panic-after-oom with host resources from the merge queue.
alexcrichton added PR #14755 Fix a possible panic-after-oom with host resources to the merge queue.
github-merge-queue[bot] removed PR #14755 Fix a possible panic-after-oom with host resources from the merge queue.
alexcrichton updated PR #14755.
alexcrichton has enabled auto merge for PR #14755.
alexcrichton added PR #14755 Fix a possible panic-after-oom with host resources to the merge queue.
:check: alexcrichton merged PR #14755.
alexcrichton removed PR #14755 Fix a possible panic-after-oom with host resources from the merge queue.
Last updated: Oct 31 2026 at 23:03 UTC