Stream: git-wasmtime

Topic: wasmtime / PR #14738 ensure fibers are disposed gracefull...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 15:29):

alexcrichton opened PR #14738 from alexcrichton:more-graceful-dispose to bytecodealliance:main:

This avoids panics in favor of bail_bugs when the guest yields in a start function. More work will be needed to avoid the bail_bugs.

part of https://github.com/bytecodealliance/wasmtime/security/advisories/GHSA-5hhx-4wrr-3j9g

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 15:29):

alexcrichton requested wasmtime-core-reviewers for a review on PR #14738.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 15:29):

alexcrichton requested pchickey for a review on PR #14738.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 16:20):

alexcrichton unassigned pchickey from PR #14738 ensure fibers are disposed gracefully in StoreOpaque::resume_fiber.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 16:20):

alexcrichton requested dicej for a review on PR #14738.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 16:21):

alexcrichton commented on PR #14738:

This heavily conflicts with https://github.com/bytecodealliance/wasmtime/pull/14620, but @dicej my thinking is that this change is no longer needed after that refactoring. Can you double-check me to confirm though?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 17:46):

dicej commented on PR #14738:

This heavily conflicts with #14620, but @dicej my thinking is that this change is no longer needed after that refactoring. Can you double-check me to confirm though?

Agreed, yes. We just need to make sure the test from the advisory PR makes it to main somehow.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 17:57):

:cross_mark: alexcrichton closed without merge PR #14738.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 17:57):

alexcrichton commented on PR #14738:

Ok I'm going to close in that case. This was the one that was difficult to test since it was triggering bail_bug!s still and otherwise everything's been well-tested so far.


Last updated: Oct 31 2026 at 23:03 UTC