Stream: git-wasmtime

Topic: wasmtime / PR #14715 fix(wasi-http): replace values in `F...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 10:52):

rvolosatovs requested pchickey for a review on PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 10:52):

rvolosatovs requested wasmtime-wasi-reviewers for a review on PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 10:52):

rvolosatovs opened PR #14715 from rvolosatovs:wasi-http-set-full-map to bytecodealliance:main:

set is documented as *replacing* values, therefore any existing values must first be cleared. Empty value list is treated as deletion.

Follow-up to https://github.com/bytecodealliance/wasmtime/pull/14702 (see my review before I merged the PR)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 10:53):

rvolosatovs edited PR #14715:

set is documented as *replacing* values, therefore any existing values must first be cleared. Empty value list is treated as deletion.

Follow-up to https://github.com/bytecodealliance/wasmtime/pull/14702 (see my review before I merged the PR)

cc @xia-chao

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 10:53):

rvolosatovs has enabled auto merge for PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 10:55):

rvolosatovs edited PR #14715:

set is documented as *replacing* values, therefore any existing values must first be cleared. Empty value list is treated as deletion.

This fixes a bug, where a set on a full map fails when key is already present

Follow-up to https://github.com/bytecodealliance/wasmtime/pull/14702 (see my review before I merged the PR)

cc @xia-chao

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 10:59):

rvolosatovs updated PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 11:11):

rvolosatovs updated PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 11:14):

rvolosatovs updated PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 11:20):

rvolosatovs updated PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 12:35):

xia-chao commented on PR #14715:

Sorry, I have introduced a bug!

Perhaps the test rewrite lost some coverage, because full_map_is_not invalid syntax asserts remove_all on a full map, whereas field_map_size deletes k0 first.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 14:57):

rvolosatovs updated PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 14:59):

rvolosatovs commented on PR #14715:

Sorry, I have introduced a bug!

I think the bug was there for quite a while already :)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2026 at 15:01):

rvolosatovs updated PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 20:54):

:thumbs_up: pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 20:55):

rvolosatovs added PR #14715 fix(wasi-http): replace values in FieldMap::set to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 21:19):

:check: rvolosatovs merged PR #14715.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2026 at 21:19):

rvolosatovs removed PR #14715 fix(wasi-http): replace values in FieldMap::set from the merge queue

Last updated: Oct 31 2026 at 23:03 UTC