Wasmtime GitHub notifications bot (Oct 13 2026 at 22:02): Wasmtime GitHub notifications bot (Oct 13 2026 at 22:02):cfallin opened PR #14710 from cfallin:fix-x64-stack-frame-overflow to bytecodealliance:main:
Followup to [1]: we shouldn't impose limits on offsets -- consistent with our "pointers are just integers" stance, and to allow algebraic simplifications/folding without edge cases, we should support arbitrary arithmetic that adds and subtracts pointer values, as long as the final value is within a stack slot.
This required adding "large offset" lowering cases for completeness, which probably won't actually be used (because our stack frame size is limited), but we want to support compiling any valid IR, so they are provided and tested here.
[1]: https://github.com/bytecodealliance/wasmtime/pull/14651#discussion_r4237927622
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:02):cfallin requested wasmtime-compiler-s390x-reviewers for a review on PR #14710.
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:02):cfallin requested alexcrichton for a review on PR #14710.
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:02):cfallin requested wasmtime-compiler-reviewers for a review on PR #14710.
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:09)::thumbs_up: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:11):alexcrichton has enabled auto merge for PR #14710.
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:20):alexcrichton added PR #14710 Cranelift: generalize stack_addr offsets. to the merge queue
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:44)::check: alexcrichton merged PR #14710.
Wasmtime GitHub notifications bot (Oct 13 2026 at 22:44):alexcrichton removed PR #14710 Cranelift: generalize stack_addr offsets. from the merge queue
Last updated: Oct 31 2026 at 23:03 UTC