alexcrichton opened PR #14709 from alexcrichton:fix-cancel to bytecodealliance:main:
This commit fixes an accidental regression from #14382 where synchronous
subtask.canceldidn't juggle the switch_item quite right which could lead to concurrent deadlocks erroneously.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested pchickey for a review on PR #14709.
alexcrichton requested wasmtime-core-reviewers for a review on PR #14709.
alexcrichton unassigned pchickey from PR #14709 Fix concurrent deadlocks with a sync subtask.cancel.
alexcrichton requested dicej for a review on PR #14709.
:thumbs_up: dicej submitted PR review.
:speech_balloon: dicej created PR review comment:
// resumed in the meantime. This is our prerogative as a runtime
:memo: alexcrichton submitted PR review.
:speech_balloon: alexcrichton created PR review comment:
Wow I've been quite wrong for many years... I suppose that's my prerogative to be wrong...
alexcrichton updated PR #14709.
alexcrichton has enabled auto merge for PR #14709.
alexcrichton added PR #14709 Fix concurrent deadlocks with a sync subtask.cancel to the merge queue
:check: alexcrichton merged PR #14709.
alexcrichton removed PR #14709 Fix concurrent deadlocks with a sync subtask.cancel from the merge queue
Last updated: Oct 31 2026 at 23:03 UTC