Stream: git-wasmtime

Topic: wasmtime / PR #1470 Wiggle: changes to traits used for er...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2020 at 22:37):

pchickey opened PR #1470 from pch/wiggle_error_model to master:

These changes are required for use by Lucet downstream, so that Lucet can use its own Ctx type with the wasi-common::witx::types.

Together, these two traits encapsulate the same functionality as previously found in GuestErrorType, but by splitting the conversion into a separate trait, we can implement it for many Ctx types, rather than restrict it to just the Ctx given at the invocation of the wiggle::from_witx macro.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2020 at 22:37):

pchickey requested alexcrichton for a review on PR #1470.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 14:49):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 16:31):

kubkon submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 16:31):

kubkon submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 16:31):

kubkon created PR Review Comment:

I guess fn error_types() is a new method and requires FF on WASI submodule?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 20:41):

pchickey updated PR #1470 from pch/wiggle_error_model to master:

These changes are required for use by Lucet downstream, so that Lucet can use its own Ctx type with the wasi-common::witx::types.

Together, these two traits encapsulate the same functionality as previously found in GuestErrorType, but by splitting the conversion into a separate trait, we can implement it for many Ctx types, rather than restrict it to just the Ctx given at the invocation of the wiggle::from_witx macro.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 20:43):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 20:43):

pchickey created PR Review Comment:

Yes, that was added in 0.8.5. In my haste I forgot to add that commit.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 20:43):

pchickey requested kubkon for a review on PR #1470.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2020 at 23:17):

pchickey updated PR #1470 from pch/wiggle_error_model to master:

These changes are required for use by Lucet downstream, so that Lucet can use its own Ctx type with the wasi-common::witx::types.

Together, these two traits encapsulate the same functionality as previously found in GuestErrorType, but by splitting the conversion into a separate trait, we can implement it for many Ctx types, rather than restrict it to just the Ctx given at the invocation of the wiggle::from_witx macro.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2020 at 02:46):

pchickey merged PR #1470.


Last updated: Dec 23 2024 at 12:05 UTC