Stream: git-wasmtime

Topic: wasmtime / PR #1470 Wiggle: changes to traits used for er...

Wasmtime GitHub notifications bot (Apr 03 2020 at 22:37):

pchickey opened PR #1470 from pch/wiggle_error_model to master:

These changes are required for use by Lucet downstream, so that Lucet can use its own Ctx type with the wasi-common::witx::types.

• Change the GuestErrorType trait to drop the associated Ctx type and have just one method fn success() -> Self. Like before, this is required for giving the right ABI return value for e.g. an Errno::Ok after a trait method with signature Result<A, Errno> returns an Ok(A{...}).

• Emit a new trait GuestErrorConversion in the types module. This trait gets implemented for any Ctx type that needs to be responsible for transforming a GuestError into a type used as a witx error type (e.g. Errno)

Together, these two traits encapsulate the same functionality as previously found in GuestErrorType, but by splitting the conversion into a separate trait, we can implement it for many Ctx types, rather than restrict it to just the Ctx given at the invocation of the wiggle::from_witx macro.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 03 2020 at 22:37):

pchickey requested alexcrichton for a review on PR #1470.

Wasmtime GitHub notifications bot (Apr 06 2020 at 14:49):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 16:31):

kubkon submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 16:31):

kubkon submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 16:31):

kubkon created PR Review Comment:

I guess fn error_types() is a new method and requires FF on WASI submodule?

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:41):

pchickey updated PR #1470 from pch/wiggle_error_model to master:

These changes are required for use by Lucet downstream, so that Lucet can use its own Ctx type with the wasi-common::witx::types.

• Change the GuestErrorType trait to drop the associated Ctx type and have just one method fn success() -> Self. Like before, this is required for giving the right ABI return value for e.g. an Errno::Ok after a trait method with signature Result<A, Errno> returns an Ok(A{...}).

• Emit a new trait GuestErrorConversion in the types module. This trait gets implemented for any Ctx type that needs to be responsible for transforming a GuestError into a type used as a witx error type (e.g. Errno)

Together, these two traits encapsulate the same functionality as previously found in GuestErrorType, but by splitting the conversion into a separate trait, we can implement it for many Ctx types, rather than restrict it to just the Ctx given at the invocation of the wiggle::from_witx macro.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:43):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:43):

pchickey created PR Review Comment:

Yes, that was added in 0.8.5. In my haste I forgot to add that commit.

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:43):

pchickey requested kubkon for a review on PR #1470.

Wasmtime GitHub notifications bot (Apr 06 2020 at 23:17):

pchickey updated PR #1470 from pch/wiggle_error_model to master:

These changes are required for use by Lucet downstream, so that Lucet can use its own Ctx type with the wasi-common::witx::types.

• Change the GuestErrorType trait to drop the associated Ctx type and have just one method fn success() -> Self. Like before, this is required for giving the right ABI return value for e.g. an Errno::Ok after a trait method with signature Result<A, Errno> returns an Ok(A{...}).

• Emit a new trait GuestErrorConversion in the types module. This trait gets implemented for any Ctx type that needs to be responsible for transforming a GuestError into a type used as a witx error type (e.g. Errno)

Together, these two traits encapsulate the same functionality as previously found in GuestErrorType, but by splitting the conversion into a separate trait, we can implement it for many Ctx types, rather than restrict it to just the Ctx given at the invocation of the wiggle::from_witx macro.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 07 2020 at 02:46):

pchickey merged PR #1470.

Last updated: Nov 22 2024 at 16:03 UTC