Stream: git-wasmtime

Topic: wasmtime / PR #1469 Wiggle: tweaks to internal interfaces

Wasmtime GitHub notifications bot (Apr 03 2020 at 22:30):

pchickey opened PR #1469 from pch/wiggle_internal_interfaces to master:

These minor changes are required for downstream use in Lucet. No functional change for users of wiggle in this tree.

• define_func is given trait name explicitly, so that method dispatch is unambiguous
• Names::new doesn't require a whole Config struct, it just requires the name of the Ctx type.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 03 2020 at 22:31):

pchickey requested kubkon for a review on PR #1469.

Wasmtime GitHub notifications bot (Apr 05 2020 at 18:12):

kubkon submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 14:51):

alexcrichton merged PR #1469.

Last updated: Dec 23 2024 at 13:07 UTC