Stream: git-wasmtime

Topic: wasmtime / PR #1467 Add Wasmtime-specific C API functions...

Wasmtime GitHub notifications bot (Apr 03 2020 at 21:32):

alexcrichton opened PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 03 2020 at 22:04):

alexcrichton updated PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 06 2020 at 14:47):

alexcrichton updated PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 06 2020 at 14:57):

alexcrichton updated PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 06 2020 at 16:05):

alexcrichton updated PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 06 2020 at 17:49):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 17:49):

peterhuene created PR Review Comment:

Nit: I realize this is example code (although the amount of example code that ends up in use is always surprising), but it's a bit strange, at least to me, for a function called print_error to exit. Perhaps exit_with_error or something similar?

Wasmtime GitHub notifications bot (Apr 06 2020 at 17:49):

peterhuene created PR Review Comment:

This (and the similar changes above) is the source of the .NET CI failures since it's now the inverse of what the .NET code is expecting (i.e. return value of 0 is now success rather than failure).

As I'm now moving the .NET code to wasmtime-dotnet, so we just merge this in with failing CI and fix it there or do you want to get this CI green and I'll port the fix to the other repo?

Wasmtime GitHub notifications bot (Apr 06 2020 at 17:49):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 17:49):

peterhuene created PR Review Comment:

This appears unreachable due to the exit in print_error.

Wasmtime GitHub notifications bot (Apr 06 2020 at 18:35):

alexcrichton updated PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:14):

alexcrichton updated PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:29):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:29):

alexcrichton created PR Review Comment:

Indeed! Mind double-checking my C# to confirm that what's there is reasonable?

(it's somewhat intentionally not fully fleshed out in every spot since I figured you'll want to tweak APIs further as well)

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:42):

peterhuene created PR Review Comment:

I'll make a note that we should probably be throwing here rather than return bool, but this is fine for now.

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:42):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:44):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:44):

peterhuene created PR Review Comment:

Is this necessary? From the C API trap messages are null terminated (for some reason...), but for our API we don't have to do that I assume.

Wasmtime GitHub notifications bot (Apr 06 2020 at 19:44):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:12):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:12):

alexcrichton created PR Review Comment:

That's what I get for blindly copy/pasting this from the TrapException code

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:12):

alexcrichton updated PR #1467 from enhanced-c-api to master:

This commit adds new wasmtime_* symbols to the C API, many of which
mirror the existing counterparts in the wasm.h header. These APIs are
enhanced in a number of respects:

• Detailed error information is now available through a
  wasmtime_error_t. Currently this only exposes one function which is
  to extract a string version of the error.

• There is a distinction now between traps and errors during
  instantiation and function calling. Traps only happen if wasm traps,
  and errors can happen for things like runtime type errors when
  interacting with the API.

• APIs have improved safety with respect to embedders where the lengths
  of arrays are now taken as explicit parameters rather than assumed
  from other parameters.

Wasmtime GitHub notifications bot (Apr 06 2020 at 20:13):

alexcrichton merged PR #1467.

Last updated: Nov 22 2024 at 16:03 UTC