Stream: git-wasmtime

Topic: wasmtime / PR #14662 wasi: remove directories named with ...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2026 at 22:24):

msuozzo opened PR #14662 from msuozzo:push-mvxolrzzuoyr to bytecodealliance:main:

remove_dir split dir/ into the parent dir and the leaf ., so
removing a directory through a path with a trailing slash failed in p1,
p2 and p3: with EINVAL on Linux and macOS, and with EACCES on Windows,
where open_parent holds the directory open. POSIX, Linux and macOS
remove the directory. This used to work: the test was ignored on every
OS with the move to cap-std (#2487), and #7553 replaced its assertion
with a comment citing OS differences.

WebAssembly/wasi-testsuite, the shared WASI test suite, expects this to
succeed: its p1 test was relaxed to accept Wasmtime's EACCES on Windows
(WebAssembly/wasi-testsuite#248) and EINVAL on Linux and macOS
(WebAssembly/wasi-testsuite#249), and its p3 test skips the case with a
FIXME pointing at #11524.

Now a trailing slash after a directory is dropped and the directory is
removed by name, as create_dir already does. Other paths, including
symlinks with a trailing slash, resolve as before.

Fixes #11524

prtest: full

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2026 at 22:24):

msuozzo requested rvolosatovs for a review on PR #14662.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2026 at 22:24):

msuozzo requested wasmtime-wasi-reviewers for a review on PR #14662.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2026 at 22:24):

msuozzo requested dicej for a review on PR #14662.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2026 at 22:24):

msuozzo requested wasmtime-core-reviewers for a review on PR #14662.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2026 at 22:24):

msuozzo updated PR #14662.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 11 2026 at 22:24):

msuozzo edited PR #14662:

remove_dir split dir/ into the parent dir and the leaf ., so
removing a directory through a path with a trailing slash failed in p1,
p2 and p3: with EINVAL on Linux and macOS, and with EACCES on Windows,
where open_parent holds the directory open. POSIX, Linux and macOS
remove the directory. This used to work: the test was ignored on every
OS with the move to cap-std (#2487), and #7553 replaced its assertion
with a comment citing OS differences.

WebAssembly/wasi-testsuite, the shared WASI test suite, expects this to
succeed: its p1 test was relaxed to accept Wasmtime's EACCES on Windows
(WebAssembly/wasi-testsuite#248) and EINVAL on Linux and macOS
(WebAssembly/wasi-testsuite#249), and its p3 test skips the case with a
FIXME pointing at #11524.

Now a trailing slash after a directory is dropped and the directory is
removed by name, as create_dir already does. Other paths, including
symlinks with a trailing slash, resolve as before.

prtest:full

Fixes #11524

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2026 at 01:28):

github-actions[bot] added the label wasi on PR #14662.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2026 at 14:49):

:thumbs_up: rvolosatovs submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2026 at 14:49):

rvolosatovs added PR #14662 wasi: remove directories named with a trailing slash to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2026 at 15:13):

:check: rvolosatovs merged PR #14662.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2026 at 15:13):

rvolosatovs removed PR #14662 wasi: remove directories named with a trailing slash from the merge queue.

Last updated: Oct 31 2026 at 23:03 UTC