cfallin opened PR #14643 from cfallin:fix-windows-unwind to bytecodealliance:main:
Fixes two separate issues:
- Scale factor for SaveReg should be 8, not 16; the encoded offset was off by a factor of two.
- We need to emit a StackAlloc op to align the implicit frame with reality.
The unwind info is not correctness-critical for Wasmtime (we have our own unwinder) but could matter for native debugging or profiling on Windows systems.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
cfallin requested alexcrichton for a review on PR #14643.
cfallin requested wasmtime-compiler-reviewers for a review on PR #14643.
:thumbs_up: alexcrichton submitted PR review.
alexcrichton added PR #14643 Cranelift: fix Windows unwind info. to the merge queue
github-merge-queue[bot] removed PR #14643 Cranelift: fix Windows unwind info. from the merge queue
github-actions[bot] added the label cranelift on PR #14643.
cfallin updated PR #14643.
cfallin has enabled auto merge for PR #14643.
cfallin added PR #14643 Cranelift: fix Windows unwind info. to the merge queue
:check: cfallin merged PR #14643.
cfallin removed PR #14643 Cranelift: fix Windows unwind info. from the merge queue
Last updated: Oct 11 2026 at 04:10 UTC