Stream: git-wasmtime

Topic: wasmtime / PR #14631 Cranelift: ISLE: opt: add missing `t...

Wasmtime GitHub notifications bot (Oct 09 2026 at 18:10):

avanhatt opened PR #14631 from avanhatt:i32x2-scalar-guards to bytecodealliance:main:

With changes to include more vector logic, the ISLE verifier found several more cases related to #14566 where mid-end rules are not correctly guarded to exclude vector 64-bit vector types such as i32x2. Theiconst_s and iconst_u terms handle scalars, i128, and 128-bit vectors, so attempts to build 64-bit vector constants fail to match and cause compiler panics.

• (#14566) (x >> k) << k -> x & mask (shifts.isle:27, shifts.isle:32) is guarded by fits_in_64 and builds an invalid iconst of vector type.
• (~x) + x -> -1 and x + (~x) -> -1 (arithmetic.isle:333, arithmetic.isle:334) build iconst_s without guard.
• -(~x) -> x + 1 and ~(-x) -> x - 1 (arithmetic.isle:590, arithmetic.isle:593) build iconst_u without guard.

This PR adds filetests for each and fixes with ty_int guards. Fixes #14566. Will put up verifier/spec changes as separate PR.

Wasmtime GitHub notifications bot (Oct 09 2026 at 18:10):

avanhatt requested wasmtime-compiler-reviewers for a review on PR #14631.

Wasmtime GitHub notifications bot (Oct 09 2026 at 18:10):

avanhatt requested fitzgen for a review on PR #14631.

Wasmtime GitHub notifications bot (Oct 09 2026 at 19:46):

github-actions[bot] added the label cranelift on PR #14631.

Wasmtime GitHub notifications bot (Oct 09 2026 at 19:46):

github-actions[bot] added the label isle on PR #14631.

Wasmtime GitHub notifications bot (Oct 09 2026 at 19:57):

:thumbs_up: cfallin submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Oct 09 2026 at 19:57):

cfallin added PR #14631 Cranelift: ISLE: opt: add missing ty_int guards to 6 rules to the merge queue.

Wasmtime GitHub notifications bot (Oct 09 2026 at 20:50):

github-actions[bot] commented on PR #14631:

Subscribe to Label Action

cc @avanhatt, @cfallin, @fitzgen, @mmcloughlin

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• avanhatt: isle
• cfallin: isle
• fitzgen: isle
• mmcloughlin: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 09 2026 at 21:56):

cfallin removed PR #14631 Cranelift: ISLE: opt: add missing ty_int guards to 6 rules from the merge queue.

Wasmtime GitHub notifications bot (Oct 09 2026 at 21:56):

:check: cfallin merged PR #14631.

Last updated: Oct 11 2026 at 04:10 UTC