Stream: git-wasmtime

Topic: wasmtime / PR #14624 save and restore `next_switch_item` ...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 15:49):

dicej opened PR #14624 from dicej:fix-14562 to bytecodealliance:main:

We were doing this correctly for other types of calls, but somehow never thought of or tested for sync-to-sync calls :facepalm:.

Since we're not switching fibers in this case, we need to use a Vec as a stack instead of the call stack, which is slightly annoying, but not a big deal.

Fixes #14562

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 15:49):

dicej requested cfallin for a review on PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 15:49):

dicej requested wasmtime-core-reviewers for a review on PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 15:51):

dicej requested alexcrichton for a review on PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 15:51):

dicej unassigned cfallin from PR #14624 save and restore next_switch_item for sync-to-sync calls.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 16:09):

:thumbs_up: alexcrichton submitted PR review:

Mind updating assert_concurrent_state_empty to check this field as well?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 16:56):

dicej updated PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 16:56):

dicej has enabled auto merge for PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 17:04):

dicej has disabled auto merge for PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 17:04):

dicej has disabled auto merge for PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 17:06):

dicej updated PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 17:07):

dicej has enabled auto merge for PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 17:16):

dicej added PR #14624 save and restore next_switch_item for sync-to-sync calls to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 17:39):

:check: dicej merged PR #14624.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 17:39):

dicej removed PR #14624 save and restore next_switch_item for sync-to-sync calls from the merge queue.


Last updated: Oct 11 2026 at 04:10 UTC