dicej opened PR #14624 from dicej:fix-14562 to bytecodealliance:main:
We were doing this correctly for other types of calls, but somehow never thought of or tested for sync-to-sync calls :facepalm:.
Since we're not switching fibers in this case, we need to use a
Vecas a stack instead of the call stack, which is slightly annoying, but not a big deal.Fixes #14562
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
dicej requested cfallin for a review on PR #14624.
dicej requested wasmtime-core-reviewers for a review on PR #14624.
dicej requested alexcrichton for a review on PR #14624.
dicej unassigned cfallin from PR #14624 save and restore next_switch_item for sync-to-sync calls.
:thumbs_up: alexcrichton submitted PR review:
Mind updating
assert_concurrent_state_emptyto check this field as well?
dicej updated PR #14624.
dicej has enabled auto merge for PR #14624.
dicej has disabled auto merge for PR #14624.
dicej has disabled auto merge for PR #14624.
dicej updated PR #14624.
dicej has enabled auto merge for PR #14624.
dicej added PR #14624 save and restore next_switch_item for sync-to-sync calls to the merge queue.
:check: dicej merged PR #14624.
dicej removed PR #14624 save and restore next_switch_item for sync-to-sync calls from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC