Stream: git-wasmtime

Topic: wasmtime / PR #14621 cranelift: Print memory flags on ato...

Wasmtime GitHub notifications bot (Oct 09 2026 at 05:19):

SashaMIT opened PR #14621 from SashaMIT:fix/atomic-memflags-print to bytecodealliance:main:

Issue #14572.

atomic_rmw and atomic_cas were printed without their memory flags. A big read-modify-write came back as native endian, so the round trip changed the result. The report's example returns 0x01020314 instead of 0x11020304.

Load and store already print MemFlags. These two arms now do the same. cranelift/filetests/filetests/parser/atomic-memflags.clif checks big on atomic_rmw and little on atomic_cas. With the old arms, filecheck misses both lines.

Printing CLIF and parsing it again is enough to lose the endianness. No guest or host authority is involved. The parser already accepted the flags.

Made with Cursor

Wasmtime GitHub notifications bot (Oct 09 2026 at 05:19):

SashaMIT requested cfallin for a review on PR #14621.

Wasmtime GitHub notifications bot (Oct 09 2026 at 05:19):

SashaMIT requested wasmtime-compiler-reviewers for a review on PR #14621.

Wasmtime GitHub notifications bot (Oct 09 2026 at 05:19):

SashaMIT edited PR #14621:

Issue #14572.

atomic_rmw and atomic_cas were printed without their memory flags. A big read-modify-write came back as native endian, so the round trip changed the result. The report's example returns 0x01020314 instead of 0x11020304.

Load and store already print MemFlags. These two arms now do the same. cranelift/filetests/filetests/parser/atomic-memflags.clif checks big on atomic_rmw and little on atomic_cas. With the old arms, filecheck misses both lines.

Printing CLIF and parsing it again drops the endianness. The parser already accepted the flags.

Wasmtime GitHub notifications bot (Oct 09 2026 at 08:56):

github-actions[bot] added the label cranelift on PR #14621.

Wasmtime GitHub notifications bot (Oct 09 2026 at 18:40):

:thumbs_up: cfallin submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Oct 09 2026 at 18:40):

cfallin added PR #14621 cranelift: Print memory flags on atomic_rmw and atomic_cas to the merge queue.

Wasmtime GitHub notifications bot (Oct 09 2026 at 19:20):

:check: cfallin merged PR #14621.

Wasmtime GitHub notifications bot (Oct 09 2026 at 19:20):

cfallin removed PR #14621 cranelift: Print memory flags on atomic_rmw and atomic_cas from the merge queue.

Wasmtime GitHub notifications bot (Oct 10 2026 at 04:35):

SashaMIT commented on PR #14621:

Thanks for the review and the merge.

Last updated: Oct 11 2026 at 04:10 UTC