Stream: git-wasmtime

Topic: wasmtime / PR #14613 wasi-http: make the p3 outgoing body...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 14:31):

xia-chao opened PR #14613 from xia-chao:feat/wasi-http-p3-outgoing-body-buffer-chunks to bytecodealliance:main:

p3 outgoing bodies now buffer one chunk at a time. Made it configurable like p2.
Fixes #14160.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 14:31):

xia-chao requested rvolosatovs for a review on PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 14:31):

xia-chao requested wasmtime-wasi-reviewers for a review on PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 15:15):

xia-chao edited PR #14613:

Fixes #14160, also wired the outgoing body CLI options up to p3.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 15:15):

xia-chao requested cfallin for a review on PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 15:15):

xia-chao updated PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 15:15):

xia-chao requested wasmtime-core-reviewers for a review on PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 15:40):

pchickey requested pchickey for a review on PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 15:40):

pchickey unassigned cfallin from PR #14613 wasi-http: make the p3 outgoing body buffering configurable.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 17:03):

:memo: rvolosatovs submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 17:03):

:speech_balloon: rvolosatovs created PR review comment:

This should probably be capped to https://docs.rs/tokio/latest/tokio/sync/struct.Semaphore.html#associatedconstant.MAX_PERMITS

Also, is the empty slot actually required? I'm expect this to be buffer_chunks, especially since it's already .max(1) on L344

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 17:40):

:memo: xia-chao submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 17:40):

:speech_balloon: xia-chao created PR review comment:

Give a super large bufferwhunks, it can really panic, empty slots are not necessary!
Thank you!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 17:41):

xia-chao updated PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 18:14):

xia-chao updated PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 18:21):

xia-chao commented on PR #14613:

Clamped both. p2 had the same panic.
And then left p2's extra slot alone, dropped the p3 one.
And then added testing.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 19:29):

:thumbs_up: rvolosatovs submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 19:29):

rvolosatovs added PR #14613 wasi-http: make the p3 outgoing body buffering configurable to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 19:51):

:check: rvolosatovs merged PR #14613.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2026 at 19:51):

rvolosatovs removed PR #14613 wasi-http: make the p3 outgoing body buffering configurable from the merge queue.

Last updated: Oct 11 2026 at 04:10 UTC