Wasmtime GitHub notifications bot (Oct 07 2026 at 19:05): Wasmtime GitHub notifications bot (Oct 07 2026 at 19:05):alexcrichton opened PR #14610 from alexcrichton:fix-thread-new-indirect to bytecodealliance:main:
This commit adjusts the type-check of the function passed to
thread.new-indirectin a few ways:
- The type-check is now more optimal -- previously a new
FuncTypewas created which requires taking engine locks, not a fast path.- The type-check now checks against the type immediate on the
thread.new-indirectinstruction.The latter part here is intended to fix spawns with types that are structurally-the-same-but-distinct, basically handling the GC-introduced type hierarchy for functions and interning. Now a
thread.new-indirectintrinsic accepts exactly only functions of the type that it was annotated with. New intrinsics can be created if necessary for other types within a guest.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 07 2026 at 19:05):alexcrichton requested cfallin for a review on PR #14610.
Wasmtime GitHub notifications bot (Oct 07 2026 at 19:05):alexcrichton requested wasmtime-core-reviewers for a review on PR #14610.
Wasmtime GitHub notifications bot (Oct 07 2026 at 22:47):github-actions[bot] added the label wasmtime:api on PR #14610.
Wasmtime GitHub notifications bot (Oct 09 2026 at 20:36)::thumbs_up: cfallin submitted PR review.
Wasmtime GitHub notifications bot (Oct 09 2026 at 20:36):cfallin added PR #14610 Fix and optimize type check when spawning threads to the merge queue.
Wasmtime GitHub notifications bot (Oct 10 2026 at 00:15)::check: cfallin merged PR #14610.
Wasmtime GitHub notifications bot (Oct 10 2026 at 00:15):cfallin removed PR #14610 Fix and optimize type check when spawning threads from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC