Stream: git-wasmtime

Topic: wasmtime / PR #14607 cranelift(x64): reuse shared i32 sum...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2026 at 18:26):

Theodus edited PR #14607.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2026 at 18:39):

Theodus has marked PR #14607 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2026 at 19:47):

github-actions[bot] added the label cranelift on PR #14607.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2026 at 19:47):

github-actions[bot] added the label cranelift:area:x64 on PR #14607.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 19:38):

alexcrichton requested cfallin for a review on PR #14607.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 19:38):

alexcrichton unassigned alexcrichton from PR #14607 cranelift(x64): reuse shared i32 sums in addressing mode.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 19:45):

:thumbs_up: cfallin submitted PR review:

Looks good, thanks! Just a comment on the test style but the actual change LGTM. (Thanks for the patience and care in running benchmarks on this one too.)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 19:45):

:speech_balloon: cfallin created PR review comment:

Let's make this a precise-output test so that we can easily re-bless when we make global changes (e.g. anything that shifts regalloc results). You can add precise-output at the end of this test line (See other filetests here) and then CRANELIFT_TEST_BLESS=1 cargo test -p cranelift-tools --test filetests to update the file with a captured output snapshot.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 19:54):

Theodus updated PR #14607.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 19:54):

:memo: Theodus submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 19:54):

:speech_balloon: Theodus created PR review comment:

Fixed in 1d9ab43

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 22:51):

:thumbs_up: cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 22:51):

cfallin added PR #14607 cranelift(x64): reuse shared i32 sums in addressing mode to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 23:13):

:check: cfallin merged PR #14607.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2026 at 23:13):

cfallin removed PR #14607 cranelift(x64): reuse shared i32 sums in addressing mode from the merge queue.

Last updated: Oct 31 2026 at 23:03 UTC