simolus3 opened PR #14605 from simolus3:gc-page-size to bytecodealliance:main:
This adds the
gc_heap_page_size_log2option, which can be used to control the page size of the memory used for GC allocations.Matching an existing assertion on memory page sizes, the only allowed values are
0(1 byte pages) and16(64k pages). Exposing this uncovered a few issues related to how memory growth is computed (which didn't take alignment into account and could thus grow memory by an incorrect amount, something that 64k pages hide).Closes https://github.com/bytecodealliance/wasmtime/issues/14523.
simolus3 requested alexcrichton for a review on PR #14605.
simolus3 requested wasmtime-core-reviewers for a review on PR #14605.
simolus3 requested wasmtime-default-reviewers for a review on PR #14605.
github-actions[bot] added the label wasmtime:config on PR #14605.
github-actions[bot] added the label wasmtime:api on PR #14605.
github-actions[bot] added the label wasmtime:ref-types on PR #14605.
github-actions[bot] commented on PR #14605:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
github-actions[bot] commented on PR #14605:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
:memo: alexcrichton submitted PR review.
:speech_balloon: alexcrichton created PR review comment:
Given how long these tests take in CI, we'll want to avoid adding this. That being said it's good to confirm here (and probably you did this locally too) that this works.
To replace this though -- can you update the fuzzing crate to configure this option?
:speech_balloon: alexcrichton created PR review comment:
This is pertty different from the code it's replacing and it additionally has an unchecked multiplication which was previously saturating -- could you comment a bit more on this change?
:speech_balloon: alexcrichton created PR review comment:
This feels not quite accurate in that shouldn't the alignment be an argument? With
v128in the GC heap I'd expect that alignments could get up to 16. (or am I misremembering and everything is aligned at 8?)
Last updated: Oct 11 2026 at 04:10 UTC