Wasmtime GitHub notifications bot (Oct 06 2026 at 15:23): Wasmtime GitHub notifications bot (Oct 06 2026 at 15:23):alexcrichton requested dicej for a review on PR #14574.
Wasmtime GitHub notifications bot (Oct 06 2026 at 15:23):alexcrichton opened PR #14574 from alexcrichton:more-adapters-on-the-host to bytecodealliance:main:
Prior to this commit adapters were fully compiled inline for sync<->sync adapters, but only if the lift/lowers were sync. This was incorrect when the intermediate function type was
async, however, in a number of ways. This bug led to a number ofbail_bug!s and incorrect execution when using the FACT-compiled adapter. The fix in this commit is to route async-typed adapted functions through the host like other async items. This additionally refactors things internally with less duplication, for examplesync_startandasync_startare nowstart_call, and the various cases in the trampoline compiler are consolidated into one.This changes preexisting behavior of one test, with the comment of the test adjusted from explaining the prior behavior to explaining the current behavior.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 06 2026 at 15:23):alexcrichton requested cfallin for a review on PR #14574.
Wasmtime GitHub notifications bot (Oct 06 2026 at 15:23):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #14574.
Wasmtime GitHub notifications bot (Oct 06 2026 at 15:23):alexcrichton requested wasmtime-core-reviewers for a review on PR #14574.
Wasmtime GitHub notifications bot (Oct 06 2026 at 16:50):github-actions[bot] added the label wasmtime:api on PR #14574.
Wasmtime GitHub notifications bot (Oct 07 2026 at 14:40)::thumbs_up: dicej submitted PR review:
Thanks for doing this!
Wasmtime GitHub notifications bot (Oct 07 2026 at 14:40)::speech_balloon: dicej created PR review comment:
These tests should probably migrate to the spec repo at some point.
Wasmtime GitHub notifications bot (Oct 07 2026 at 14:59)::memo: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 07 2026 at 14:59)::speech_balloon: alexcrichton created PR review comment:
Definitely yeah, we'll need some sort of reconciling at some point...
Wasmtime GitHub notifications bot (Oct 07 2026 at 14:59):alexcrichton added PR #14574 Route more component adapters to the host to the merge queue.
Wasmtime GitHub notifications bot (Oct 07 2026 at 15:22)::check: alexcrichton merged PR #14574.
Wasmtime GitHub notifications bot (Oct 07 2026 at 15:22):alexcrichton removed PR #14574 Route more component adapters to the host from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC