Stream: git-wasmtime

Topic: wasmtime / PR #14543 bindgen: use fully-qualified paths f...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:33):

scothis requested wasmtime-core-reviewers for a review on PR #14543.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:33):

scothis requested cfallin for a review on PR #14543.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:33):

scothis opened PR #14543 from scothis:bindgen-prelude-conflict to bytecodealliance:main:

Generated bindings referred to Result, Option, and core::... items by bare or relative paths. These broke when a WIT interface defined a type whose name collides with a prelude item, such as type %result = bool; or type %option = bool;. The generated pub type Result = bool; would shadow the prelude, so later uses of Result<...> in the same module failed to compile.

Generated code now uses ::core::result::Result,
::core::option::Option, and ::core::... for the fmt, error, and convert traits. This way user-defined type names can't shadow them.

Add a codegen test with interface types named result and option, and regenerate the expanded test outputs.

A similar change was made in https://github.com/bytecodealliance/wit-bindgen/pull/1676

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 17:30):

:thumbs_up: pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 17:30):

pchickey added PR #14543 bindgen: use fully-qualified paths for prelude types to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 17:54):

:check: pchickey merged PR #14543.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 17:54):

pchickey removed PR #14543 bindgen: use fully-qualified paths for prelude types from the merge queue.


Last updated: Oct 11 2026 at 04:10 UTC