Stream: git-wasmtime

Topic: wasmtime / PR #14540 [stack-switching] Bounds-check conti...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:04):

dhil requested wasmtime-compiler-reviewers for a review on PR #14540.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:05):

dhil requested wasmtime-core-reviewers for a review on PR #14540.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:06):

dhil opened PR #14540 from dhil:stack-switching-bounds to bytecodealliance:main:

This patch adds a defensive check in occupy_next_slot, ensuring that a continuation's data buffer has sufficient capacity. I believe a well-typed Wasm program should never be able to fail this check, thus failing it ought to indicate some external tampering with continuation objects.

Resolves #13028. Note the root cause in #13028 was fixed by PR#11717. This PR resolves the issue in the sense that it adds the defensive suggestion outlined in the issue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:06):

dhil requested alexcrichton for a review on PR #14540.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:35):

:memo: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:35):

:speech_balloon: alexcrichton created PR review comment:

This test feels a bit heavyweight to me in terms of spawning processes and such, and given that the root cause here has already been fixed for the test case at hand here it might make sense to avoid adding a test for this. In a sense this PR is similar to https://github.com/bytecodealliance/wasmtime/pull/14484 (if I'm understanding it right)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:51):

:memo: dhil submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:51):

:speech_balloon: dhil created PR review comment:

Yes sure. Just my habit of adding regression tests from linked issues. I will remove it again.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:52):

dhil updated PR #14540.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 16:18):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 16:18):

alexcrichton added PR #14540 [stack-switching] Bounds-check continuation payload writes to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 16:41):

github-merge-queue[bot] removed PR #14540 [stack-switching] Bounds-check continuation payload writes from the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 16:48):

alexcrichton added PR #14540 [stack-switching] Bounds-check continuation payload writes to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 17:12):

:check: alexcrichton merged PR #14540.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 17:12):

alexcrichton removed PR #14540 [stack-switching] Bounds-check continuation payload writes from the merge queue.

Last updated: Oct 11 2026 at 04:10 UTC