Stream: git-wasmtime

Topic: wasmtime / PR #14539 Try harder to fix `serve` inheritanc...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:04):

alexcrichton requested wasmtime-core-reviewers for a review on PR #14539.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:04):

alexcrichton requested cfallin for a review on PR #14539.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 15:05):

alexcrichton opened PR #14539 from alexcrichton:try-fix-spurious to bytecodealliance:main:

The previous dup2 fix seemed to probably work for just a TCP inheritance, but with Unix now in play as well the test didn't handle this situation well enough and we're still getting [spurious failures][spurious]. This is an attempt to fix that.

[spurious]: https://github.com/bytecodealliance/wasmtime/actions/runs/37324908307/job/111813946004

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 21:25):

:thumbs_up: pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 21:25):

pchickey added PR #14539 Try harder to fix serve inheritance's test to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 21:48):

:check: pchickey merged PR #14539.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 21:48):

pchickey removed PR #14539 Try harder to fix serve inheritance's test from the merge queue.


Last updated: Oct 11 2026 at 04:10 UTC