Stream: git-wasmtime

Topic: wasmtime / PR #14522 cranelift: fix f16 and f128 comparis...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 11:09):

dotcom07 opened PR #14522 from dotcom07:fix/ieee-float-zero-comparison to bytecodealliance:main:

Ieee16::partial_cmp and Ieee128::partial_cmp return Equal whenever either operand is zero. This makes the interpreter report that 1 == 0 and that 1 > 0 is false. Require both operands to be zero for the special case, preserving equality between positive and negative zero.

Adds unit tests for both types covering signed zeros, positive and negative one, and the smallest positive and negative subnormals, with operands in both orders.

Tested with cargo +1.97.0 test -p cranelift-codegen --lib --offline (214 tests passed).

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 11:09):

dotcom07 requested cfallin for a review on PR #14522.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 11:09):

dotcom07 requested wasmtime-compiler-reviewers for a review on PR #14522.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 15:23):

github-actions[bot] added the label cranelift on PR #14522.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 16:07):

dotcom07 edited PR #14522:

Ieee16::partial_cmp and Ieee128::partial_cmp return Equal whenever either operand is zero. This makes the interpreter report that 1 == 0 and that 1 > 0 is false. Require both operands to be zero for the special case, preserving equality between positive and negative zero.

Adds unit tests for both types covering signed zeros, positive and negative one, and the smallest positive and negative subnormals, with operands in both orders.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2026 at 17:36):

cfallin commented on PR #14522:

@dotcom07 thanks for this PR. I'm the assigned reviewer but I am quite underwater this week with a bunch of other things, so I will get to it probably early or mid next week.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 18:26):

:thumbs_up: cfallin submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 18:27):

cfallin added PR #14522 cranelift: fix f16 and f128 comparisons with zero to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 18:49):

:check: cfallin merged PR #14522.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 09 2026 at 18:49):

cfallin removed PR #14522 cranelift: fix f16 and f128 comparisons with zero from the merge queue.

Last updated: Oct 11 2026 at 04:10 UTC