philipc opened PR #14519 from philipc:object-symbol-flags to bytecodealliance:main:
The default symbol flags depend on whether the symbol has been defined or not. Calling symbol_flags_mut() initialises the flags with the default, so calling it before add_symbol_data() results in the wrong flags.
philipc requested alexcrichton for a review on PR #14519.
philipc requested wasmtime-compiler-reviewers for a review on PR #14519.
github-actions[bot] added the label cranelift on PR #14519.
github-actions[bot] added the label cranelift:module on PR #14519.
:thumbs_up: alexcrichton submitted PR review.
alexcrichton added PR #14519 cranelift-object: set symbol flags after defining to the merge queue.
:check: alexcrichton merged PR #14519.
alexcrichton removed PR #14519 cranelift-object: set symbol flags after defining from the merge queue.
bjorn3 commented on PR #14519:
Thanks! I can confirm this fixes cg_clif on macOS.
Last updated: Oct 11 2026 at 04:10 UTC