Stream: git-wasmtime

Topic: wasmtime / PR #14514 cli: avoid overflow when deriving th...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2026 at 10:16):

xia-chao opened PR #14514 from xia-chao:cli-max-wasm-stack-overflow to bytecodealliance:main:

A huge -Wmax-wasm-stack crashes the CLI, because deriving the async stack size from it overflows,
while zero is already rejected with a clear error.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2026 at 10:16):

xia-chao requested pchickey for a review on PR #14514.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2026 at 10:16):

xia-chao requested wasmtime-core-reviewers for a review on PR #14514.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 23:01):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 23:01):

alexcrichton added PR #14514 cli: avoid overflow when deriving the async stack size to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 23:26):

github-merge-queue[bot] removed PR #14514 cli: avoid overflow when deriving the async stack size from the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 08:30):

xia-chao updated PR #14514.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 08:30):

xia-chao edited PR #14514:

A huge -Wmax-wasm-stack crashes the CLI, because deriving the async stack size from it overflows,
while zero is already rejected with a clear error. Such a value still fails later on a 32-bit
target, when the stack it asks for cannot be allocated -- that is how Store::new already behaves.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 08:37):

xia-chao commented on PR #14514:

@alexcrichton It has been re pushed. The failure of i686 is a testing issue, not a repair issue. 32-bit cannot allocate this stack

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 14:24):

alexcrichton added PR #14514 cli: avoid overflow when deriving the async stack size to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 14:50):

:check: alexcrichton merged PR #14514.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2026 at 14:50):

alexcrichton removed PR #14514 cli: avoid overflow when deriving the async stack size from the merge queue.


Last updated: Oct 11 2026 at 04:10 UTC