alexcrichton opened PR #14512 from alexcrichton:fix-windows-read-link to bytecodealliance:main:
Refactoring in #14370 erroneously forgot to use
open_parentto actually sandbox theread_linkfunction, and additionally even had it used that function it would not have passed tests on Windows. This commit adds a test thatread_linkcan't escape the sandbox and it additionally restores the old implementation, with the upstreamwinxcode inline.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested dicej for a review on PR #14512.
alexcrichton requested wasmtime-wasi-reviewers for a review on PR #14512.
github-actions[bot] added the label wasi on PR #14512.
:thumbs_up: dicej submitted PR review.
alexcrichton added PR #14512 Fix sandboxing in read_link on Windows to the merge queue.
github-merge-queue[bot] removed PR #14512 Fix sandboxing in read_link on Windows from the merge queue.
alexcrichton added PR #14512 Fix sandboxing in read_link on Windows to the merge queue.
:check: alexcrichton merged PR #14512.
alexcrichton removed PR #14512 Fix sandboxing in read_link on Windows from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC