Wasmtime GitHub notifications bot (Mar 31 2020 at 19:51): Wasmtime GitHub notifications bot (Mar 31 2020 at 19:51):abrown requested yurydelendik for a review on PR #1451.
Wasmtime GitHub notifications bot (Mar 31 2020 at 19:51):abrown opened PR #1451 from fix-1245 to master:
Both cranelift-codegen and wasmtime-debug need to map Cranelift registers to Gimli registers. Previously both crates had an almost-identical
map_regimplementation. This change:
- removes the wasmtime-debug implementation
- improves the cranelift-codegen implementation with custom errors
- exposes map_reg in
cranelift_codegen::isa::fde::map_regand subsequentlywasmtime_environ::isa::fde::map_reg<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 31 2020 at 19:52):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Mar 31 2020 at 19:52):abrown created PR Review Comment:
This could probably take a
&'static str?
Wasmtime GitHub notifications bot (Mar 31 2020 at 21:39):yurydelendik submitted PR Review.
Wasmtime GitHub notifications bot (Mar 31 2020 at 21:39):yurydelendik created PR Review Comment:
Yes, let's make it
&'static str.
Wasmtime GitHub notifications bot (Mar 31 2020 at 21:39):yurydelendik submitted PR Review.
Wasmtime GitHub notifications bot (Mar 31 2020 at 22:04):abrown updated PR #1451 from fix-1245 to master:
Both cranelift-codegen and wasmtime-debug need to map Cranelift registers to Gimli registers. Previously both crates had an almost-identical
map_regimplementation. This change:
- removes the wasmtime-debug implementation
- improves the cranelift-codegen implementation with custom errors
- exposes map_reg in
cranelift_codegen::isa::fde::map_regand subsequentlywasmtime_environ::isa::fde::map_reg<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 31 2020 at 22:42):abrown merged PR #1451.
Last updated: Dec 23 2024 at 12:05 UTC