Wasmtime GitHub notifications bot (Oct 02 2026 at 21:20): Wasmtime GitHub notifications bot (Oct 02 2026 at 21:20):alexcrichton opened PR #14502 from alexcrichton:refactor-winch-features to bytecodealliance:main:
I've realized locally that in addition to removing the gc-types/exceptions defaults we should also be removing tail-call by default. To handle that I've decided to refactor this slightly to explicitly enable features for Winch instead of disabling them from Cranelift's features. This should be a bit more robust over time because if we add something to Cranelift's set we don't have to remember to remove it from Winch's set.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 02 2026 at 21:20):alexcrichton requested cfallin for a review on PR #14502.
Wasmtime GitHub notifications bot (Oct 02 2026 at 21:21):alexcrichton requested wasmtime-core-reviewers for a review on PR #14502.
Wasmtime GitHub notifications bot (Oct 02 2026 at 21:40)::thumbs_up: cfallin submitted PR review:
Some thoughts below but I'm not strongly attached either way; just my idea/impression...
Wasmtime GitHub notifications bot (Oct 02 2026 at 21:40)::speech_balloon: cfallin created PR review comment:
Would it be a little easier to follow if we had something like
let mut features = WasmFeatures::empty(); match self.compiler_config.as_ref().and_then(|c| c.strategy) { // XXX does `None` mean Cranelift or no compilation? None => { features |= WasmFeatures::WASM3 | WasmFeatures::WIDE_ARITHMETIC; } #[cfg(feature = "cranelift")] Some(Strategy::CraneliftNative) | Some(Strategy::CraneliftPulley) => { features |= WasmFeatures::WASM3 | WasmFeatures::WIDE_ARITHMETIC; } #[cfg(feature = "winch")] Some(Strategy::Winch) => { features |= WasmFeatures::WASM2 | ...; features.remove(WasmFeatures::GC_TYPES); } }(I'm not as familiar with this code as you but at least naively, it feels like there should be a table-by-compiler somewhere rather than an "overwrite earlier value" flow)
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:12):alexcrichton updated PR #14502.
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:13)::memo: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:13)::speech_balloon: alexcrichton created PR review comment:
Good call, mind double-checking the docs/etc that've been subsequently updated?
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:25)::thumbs_up: cfallin submitted PR review:
LGTM, thanks!
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:25)::speech_balloon: cfallin created PR review comment:
s/meant/mean/
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:29):alexcrichton updated PR #14502.
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:29):alexcrichton has enabled auto merge for PR #14502.
Wasmtime GitHub notifications bot (Oct 02 2026 at 22:39):alexcrichton added PR #14502 Refactor Winch default features slightly to the merge queue.
Wasmtime GitHub notifications bot (Oct 02 2026 at 23:03):github-merge-queue[bot] removed PR #14502 Refactor Winch default features slightly from the merge queue.
Wasmtime GitHub notifications bot (Oct 02 2026 at 23:44):github-actions[bot] added the label wasmtime:api on PR #14502.
Wasmtime GitHub notifications bot (Oct 02 2026 at 23:44):github-actions[bot] added the label wasmtime:config on PR #14502.
Wasmtime GitHub notifications bot (Oct 03 2026 at 01:14):github-actions[bot] commented on PR #14502:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Oct 05 2026 at 14:41):alexcrichton updated PR #14502.
Wasmtime GitHub notifications bot (Oct 05 2026 at 14:41):alexcrichton has enabled auto merge for PR #14502.
Wasmtime GitHub notifications bot (Oct 05 2026 at 14:52):alexcrichton added PR #14502 Refactor Winch default features slightly to the merge queue.
Wasmtime GitHub notifications bot (Oct 05 2026 at 15:29)::check: alexcrichton merged PR #14502.
Wasmtime GitHub notifications bot (Oct 05 2026 at 15:29):alexcrichton removed PR #14502 Refactor Winch default features slightly from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC