Stream: git-wasmtime

Topic: wasmtime / PR #14501 classify default connect and TLS errors

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 20:32):

macovedj opened PR #14501 from macovedj:wasi-http-error-classification to bytecodealliance:main:

This PR distinguishes refused, unavailable, timed-out, and terminated connections in the p2 and p3 default hooks. It also preserve certificate and TLS alert details when the default request implementation is enabled.

I used rustix for unsupported-address-family errors, but happy to remove if the dependency addition isn't desirable.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 20:32):

macovedj requested pchickey for a review on PR #14501.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 20:32):

macovedj requested wasmtime-wasi-reviewers for a review on PR #14501.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 20:32):

macovedj requested alexcrichton for a review on PR #14501.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 20:32):

macovedj requested wasmtime-default-reviewers for a review on PR #14501.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 22:28):

:memo: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 22:28):

:speech_balloon: alexcrichton created PR review comment:

Could this fall back to ConnectionRefused? I'm a bit wary to stringify errors here since that seems like it could be pretty performance sensitive.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 22:28):

:speech_balloon: alexcrichton created PR review comment:

I think it's ok to probably just drop tests for this change, it's pretty brittle to test this IMO

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 22:28):

:speech_balloon: alexcrichton created PR review comment:

Given that this doesn't add much over alert_id, could this be None for now unless a guest ends up needing specific access later?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 03 2026 at 16:29):

macovedj updated PR #14501.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 23:00):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 23:00):

alexcrichton added PR #14501 classify default connect and TLS errors to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 23:24):

:check: alexcrichton merged PR #14501.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2026 at 23:24):

alexcrichton removed PR #14501 classify default connect and TLS errors from the merge queue.

Last updated: Oct 11 2026 at 02:20 UTC