Stream: git-wasmtime

Topic: wasmtime / PR #14490 Keep host subtasks alive until cance...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 17:24):

macovedj opened PR #14490 from macovedj:subtask-cancel-lifetime to bytecodealliance:main:

A guest can request asynchronous cancellation and then attempt to drop
the subtask before cancellation finishes. Previously, subtask.cancel
immediately marked the host task as done, allowing that drop even when
cancellation returned BLOCKED.

This can remove a task entry that the completion worker still references.
If another host call reuses the slot, the old completion can report
RETURN_CANCELLED for the new task, even though it was never cancelled.

This PR introduces CalleeCancelling to preserve the task entry while completion
processing is pending and rejects subtask.drop until that processing has
finished and the terminal event has been delivered.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 17:24):

macovedj requested cfallin for a review on PR #14490.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 17:24):

macovedj requested wasmtime-core-reviewers for a review on PR #14490.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 17:31):

cfallin unassigned cfallin from PR #14490 Keep host subtasks alive until cancellation completes.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 17:31):

cfallin requested dicej for a review on PR #14490.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 17:32):

cfallin commented on PR #14490:

(Going to hand off review to @dicej if that's OK, as I'm not that familiar with concurrent.rs -- I should change that eventually, but in the meantime I'm not the best reviewer, sorry!)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 17:46):

macovedj updated PR #14490.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 19:53):

:thumbs_up: dicej submitted PR review:

Thanks, @macovedj!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 19:53):

dicej added PR #14490 Keep host subtasks alive until cancellation completes to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 20:18):

:check: dicej merged PR #14490.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2026 at 20:18):

dicej removed PR #14490 Keep host subtasks alive until cancellation completes from the merge queue.


Last updated: Oct 11 2026 at 04:10 UTC