Wasmtime GitHub notifications bot (Sep 30 2026 at 17:11): Wasmtime GitHub notifications bot (Sep 30 2026 at 17:11):macovedj opened PR #14455 from macovedj:winch-typed-select-stack-maps to bytecodealliance:main:
Winch records a
selectresult using the second operand’s internal type, even for a typedselectwith a declared result type. In #14451, that operand isref.null extern, which Winch represents internally asI32. When the condition chooses the liveexternreffrom the first operand, the value is correct, but Winch still records the result asI32. The next call’s stack map then omits the live reference, so a collector can lose it.This PR records a typed
selectresult using its declared type and adds x86-64 and AArch64 stack-map tests, plus runtime tests for all collectors.Fixes #14451.
Wasmtime GitHub notifications bot (Sep 30 2026 at 17:11):macovedj requested cfallin for a review on PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 17:11):macovedj requested wasmtime-compiler-reviewers for a review on PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 17:11):macovedj requested wasmtime-core-reviewers for a review on PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 17:24):macovedj updated PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 18:26)::memo: saulecabrera submitted PR review:
LGTM; can we add a disassembly test for a live-ref/null case? I know we have runtime tests for this case, but I think a disas tests might still be useful.
Wasmtime GitHub notifications bot (Sep 30 2026 at 18:31):macovedj updated PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 18:32):macovedj updated PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 18:32):macovedj updated PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 18:33)::thumbs_up: saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Sep 30 2026 at 18:33):saulecabrera has enabled auto merge for PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 18:44):saulecabrera added PR #14455 winch: preserve typed select result type for GC stack maps to the merge queue.
Wasmtime GitHub notifications bot (Sep 30 2026 at 19:11):github-merge-queue[bot] removed PR #14455 winch: preserve typed select result type for GC stack maps from the merge queue.
Wasmtime GitHub notifications bot (Sep 30 2026 at 19:24):macovedj updated PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 19:26):macovedj commented on PR #14455:
Looks like CI failed from running on unsupported targets. Added some architecture guards.
Wasmtime GitHub notifications bot (Sep 30 2026 at 19:28):alexcrichton commented on PR #14455:
Could the tests here use
#[wasmtime_test]to avoid test-specific guards?
Wasmtime GitHub notifications bot (Sep 30 2026 at 19:33):macovedj updated PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 20:47):github-actions[bot] added the label winch on PR #14455.
Wasmtime GitHub notifications bot (Sep 30 2026 at 20:48):github-actions[bot] commented on PR #14455:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Oct 01 2026 at 17:30):saulecabrera added PR #14455 winch: preserve typed select result type for GC stack maps to the merge queue.
Wasmtime GitHub notifications bot (Oct 01 2026 at 17:59)::check: saulecabrera merged PR #14455.
Wasmtime GitHub notifications bot (Oct 01 2026 at 17:59):saulecabrera removed PR #14455 winch: preserve typed select result type for GC stack maps from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC