Wasmtime GitHub notifications bot (Sep 29 2026 at 20:54): Wasmtime GitHub notifications bot (Sep 29 2026 at 20:54):fitzgen opened PR #14450 from fitzgen:do-not-trust-the-gc-heap to bytecodealliance:main:
See each commit for details.
Wasmtime GitHub notifications bot (Sep 29 2026 at 20:54):fitzgen requested cfallin for a review on PR #14450.
Wasmtime GitHub notifications bot (Sep 29 2026 at 20:54):fitzgen requested wasmtime-core-reviewers for a review on PR #14450.
Wasmtime GitHub notifications bot (Sep 29 2026 at 21:21)::thumbs_up: alexcrichton submitted PR review:
On one hand I'm a bit hesitant of the increase in verbosity here, but on the other hand it's pretty easy to read and understand what things are doing. My main musing here I think is whether original panicking methods should be outright deleted/changed instead of growing sibling fallible versions
Wasmtime GitHub notifications bot (Sep 29 2026 at 21:21)::speech_balloon: alexcrichton created PR review comment:
Would it make sense to maybe change the preexisting methods to return a
Result?
Wasmtime GitHub notifications bot (Sep 29 2026 at 21:21)::speech_balloon: alexcrichton created PR review comment:
Should this method perhaps be deleted?
Wasmtime GitHub notifications bot (Sep 29 2026 at 21:21)::speech_balloon: alexcrichton created PR review comment:
Given the frequency of assertions like this, one idea might be a method on the header object itself?
Wasmtime GitHub notifications bot (Sep 29 2026 at 22:45):github-actions[bot] added the label wasmtime:api on PR #14450.
Wasmtime GitHub notifications bot (Sep 29 2026 at 22:45):github-actions[bot] added the label wasmtime:ref-types on PR #14450.
Wasmtime GitHub notifications bot (Sep 29 2026 at 22:46):github-actions[bot] commented on PR #14450:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Oct 01 2026 at 16:51):fitzgen updated PR #14450.
Wasmtime GitHub notifications bot (Oct 01 2026 at 16:53):fitzgen commented on PR #14450:
Thanks for the review, all good points, all addressed.
Wasmtime GitHub notifications bot (Oct 01 2026 at 18:35):fitzgen updated PR #14450.
Wasmtime GitHub notifications bot (Oct 01 2026 at 18:36):fitzgen has enabled auto merge for PR #14450.
Wasmtime GitHub notifications bot (Oct 01 2026 at 18:46):fitzgen added PR #14450 Add more defense-in-depth checks of IDs and such coming out of the GC heap to the merge queue.
Wasmtime GitHub notifications bot (Oct 01 2026 at 19:14):github-merge-queue[bot] removed PR #14450 Add more defense-in-depth checks of IDs and such coming out of the GC heap from the merge queue.
Wasmtime GitHub notifications bot (Oct 01 2026 at 19:15):alexcrichton added PR #14450 Add more defense-in-depth checks of IDs and such coming out of the GC heap to the merge queue.
Wasmtime GitHub notifications bot (Oct 01 2026 at 19:42)::check: alexcrichton merged PR #14450.
Wasmtime GitHub notifications bot (Oct 01 2026 at 19:42):alexcrichton removed PR #14450 Add more defense-in-depth checks of IDs and such coming out of the GC heap from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC