Stream: git-wasmtime

Topic: wasmtime / PR #1445 wiggle: fix cycle between wiggle and ...

Wasmtime GitHub notifications bot (Mar 31 2020 at 17:40):

pchickey opened PR #1445 from pch/wiggle-tests-fix-cycle to master:

Fix required for publishing crates:

• move all wiggle's tests underneath wiggle-test crate
• rename wiggle-test's directory from test-helpers to test, since its not just the helpers anymore
• fix the wiggle-macro doc tests
• add wiggle-test directly to workspace. I'm not sure why this is required, but for cargo test --package wiggle-test to work correctly, it appears that I needed to put crates/wiggle/test into the workspace, even though crates/wiggle was already present.

Wasmtime GitHub notifications bot (Mar 31 2020 at 17:51):

pchickey requested sunfishcode for a review on PR #1445.

Wasmtime GitHub notifications bot (Mar 31 2020 at 18:34):

pchickey updated PR #1445 from pch/wiggle-tests-fix-cycle to master:

Fix required for publishing crates:

• move all wiggle's tests underneath wiggle-test crate
• rename wiggle-test's directory from test-helpers to test, since its not just the helpers anymore
• fix the wiggle-macro doc tests
• add wiggle-test directly to workspace. I'm not sure why this is required, but for cargo test --package wiggle-test to work correctly, it appears that I needed to put crates/wiggle/test into the workspace, even though crates/wiggle was already present.

Wasmtime GitHub notifications bot (Mar 31 2020 at 18:37):

pchickey closed without merge PR #1445.

Last updated: Oct 23 2024 at 20:03 UTC