Stream: git-wasmtime

Topic: wasmtime / PR #14446 [wasmtime-wasi-http] always accept e...

Wasmtime GitHub notifications bot (Sep 28 2026 at 23:44):

dicej opened PR #14446 from dicej:empty-path-with-query-v2 to bytecodealliance:main:

The behavior of http::uri::PathAndQuery::from_str("") changed in v1.4.1 of the http crate, and although Wasmtime itself has not yet upgraded from the older version it currently depends on, embedders may end up with a newer version.

Specifically, the old behavior was to implicitly convert the empty string to a slash, whereas the new behavior is to return an error.

According to https://datatracker.ietf.org/doc/html/rfc3986#section-3.3, an empty string should be acceptable, and http::uri::Builder::path_and_query still allows them, so we use that instead. That ensures consistent behavior regardless of which version of the http crate the embedder ends up depending on.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 28 2026 at 23:44):

dicej requested pchickey for a review on PR #14446.

Wasmtime GitHub notifications bot (Sep 28 2026 at 23:44):

dicej requested wasmtime-wasi-reviewers for a review on PR #14446.

Wasmtime GitHub notifications bot (Sep 29 2026 at 01:23):

alexcrichton commented on PR #14446:

Would you be up for tracking down where/when this changed in the http crate as well? AFAIK that's also intending to be pretty standards-compliant, so I'd be curious to at least be aware of the rationale there

Wasmtime GitHub notifications bot (Sep 29 2026 at 07:03):

karthik2804 commented on PR #14446:

Here is a discussion I found - https://github.com/hyperium/http/issues/839

Wasmtime GitHub notifications bot (Sep 29 2026 at 13:10):

dicej commented on PR #14446:

Per the doc comment, the change happened in https://github.com/hyperium/http/pull/826, with a follow-up in https://github.com/hyperium/http/pull/853

Wasmtime GitHub notifications bot (Sep 29 2026 at 17:06):

:thumbs_up: alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2026 at 13:16):

dicej updated PR #14446.

Wasmtime GitHub notifications bot (Sep 30 2026 at 13:27):

dicej added PR #14446 [wasmtime-wasi-http] always accept empty path-with-query to the merge queue.

Wasmtime GitHub notifications bot (Sep 30 2026 at 14:02):

:check: dicej merged PR #14446.

Wasmtime GitHub notifications bot (Sep 30 2026 at 14:02):

dicej removed PR #14446 [wasmtime-wasi-http] always accept empty path-with-query from the merge queue.

Last updated: Oct 11 2026 at 04:10 UTC