Stream: git-wasmtime

Topic: wasmtime / PR #14443 wasi: preserve accepted TCP peer add...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 20:55):

macovedj edited PR #14443.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 20:59):

macovedj edited PR #14443:

Currently, if a client resets after its connection is accepted, remote-address can fail because we query the socket again instead of keeping the address returned by accept. This PR preserves that address so it can still be accessed after a reset.
I also updated cargo-fuzz because installing the pinned version from scratch was failing in CI.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:03):

:memo: pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:03):

:speech_balloon: pchickey created PR review comment:

In this case (implicitly, accepted_peer: None), if stream.peer_addr() succeeds, wouldn't we want to save the peer address in accepted_peer? (That would require the whole method to become &mut self). And in that case, we could rename the struct member to peer, dropping the accepted?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:30):

macovedj updated PR #14443.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:34):

:memo: macovedj submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:34):

:speech_balloon: macovedj created PR review comment:

Ah yeah, I only cached the address returned by accept because that was the case I ran into. Caching successful peer_addr results makes sense too.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:34):

:thumbs_up: pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:34):

pchickey has enabled auto merge for PR #14443.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 21:40):

pchickey added PR #14443 wasi: preserve accepted TCP peer addresses after reset to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 22:07):

:check: pchickey merged PR #14443.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 22:07):

pchickey removed PR #14443 wasi: preserve accepted TCP peer addresses after reset from the merge queue.

Last updated: Oct 11 2026 at 04:10 UTC