Stream: git-wasmtime

Topic: wasmtime / PR #14438 [stack-switching] Import spectests

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 14:55):

dhil opened PR #14438 from dhil:stack-switching-spec-tests to bytecodealliance:main:

This patch imports the cont.wast kitchen sink test file and the resume_throw.wast (named resume_throw_spec.wast here) from the https://github.com/WebAssembly/stack-switching repository.

I am positive there is some test coverage overlap here. However, I am not sure there is much point in tidying the tests right now. I think this is something that should be done on the spec repository first.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 14:55):

dhil requested pchickey for a review on PR #14438.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 14:56):

dhil requested wasmtime-core-reviewers for a review on PR #14438.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 14:56):

dhil edited PR #14438:

This patch imports the cont.wast kitchen sink test file and the resume_throw.wast (named resume_throw_spec.wast here) from the https://github.com/WebAssembly/stack-switching repository.

I am positive there is some test coverage overlap here. However, I am not sure there is much point in tidying up the tests right now. I think this is something that should be done on the spec repository first.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 17:34):

:memo: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 17:34):

:speech_balloon: alexcrichton created PR review comment:

Could this line be omitted? This is intended to ignore error messages of upstream spec tests but in this case for something vendored here I think it'd be better to tweak any mismatched errors to match Wasmtime's errors

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 17:34):

alexcrichton unassigned pchickey from PR #14438 [stack-switching] Import spectests.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 17:34):

alexcrichton requested alexcrichton for a review on PR #14438.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 17:44):

:memo: dhil submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 17:44):

:speech_balloon: dhil created PR review comment:

Yes sure, I will go through the list and change the error messages inside cont.wast and the resume_throw_spec.wast.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 18:46):

dhil updated PR #14438.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 19:07):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 19:07):

alexcrichton added PR #14438 [stack-switching] Import spectests to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 19:34):

:check: alexcrichton merged PR #14438.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2026 at 19:34):

alexcrichton removed PR #14438 [stack-switching] Import spectests from the merge queue.

Last updated: Oct 11 2026 at 02:20 UTC