Stream: git-wasmtime

Topic: wasmtime / PR #14435 [gc_fuzz]: Clean up the source of gc...

Wasmtime GitHub notifications bot (Sep 28 2026 at 00:05):

khagankhan opened PR #14435 from khagankhan:cleanup to bytecodealliance:main:

Cleanups for the gc_ops generator, following up on the review of #14276.
No semantic change in emitted modules. I hashed the Wasm binary of the first 400 seeds before and after each step and all 400 stayed identical. Sorry if it looks like too many changes (I can split) but it is just code moves:

• Replace the spelled-out heap types and the repeated table, global and null-guard instruction patterns with constants and small helpers.
• Record every type and import index where it is created, so encode no longer restates the import order as literals.
• Split to_wasm_binary into one helper per module section, and name the three typed local banks where they are declared.
• Split encode into a dispatcher plus one function per op family, with all root reads and writes going through one encode_root keyed by a RefKind.
• Split Types::fixup into named steps and rename the fixup family by what each one fixes (fixup_limits, fixup_types, fixup_immediates, fixup_operand).
• Move StackType to its own file and collapse its operand fixup into one rule plus two lookup tables.
• Add one-line docs to every function, field and variant

+cc @fitzgen

Wasmtime GitHub notifications bot (Sep 28 2026 at 00:05):

khagankhan requested wasmtime-fuzz-reviewers for a review on PR #14435.

Wasmtime GitHub notifications bot (Sep 28 2026 at 00:05):

khagankhan requested alexcrichton for a review on PR #14435.

Wasmtime GitHub notifications bot (Sep 28 2026 at 02:01):

github-actions[bot] added the label fuzzing on PR #14435.

Wasmtime GitHub notifications bot (Sep 28 2026 at 02:02):

github-actions[bot] commented on PR #14435:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 28 2026 at 17:24):

alexcrichton unassigned alexcrichton from PR #14435 [gc_fuzz]: Clean up the source of gc_ops.

Wasmtime GitHub notifications bot (Sep 28 2026 at 17:24):

alexcrichton requested fitzgen for a review on PR #14435.

Wasmtime GitHub notifications bot (Oct 05 2026 at 21:51):

:thumbs_up: fitzgen submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Oct 05 2026 at 21:51):

:speech_balloon: fitzgen created PR review comment:

Making sure this doesn't get lost, but we should still generalize these into $n$ locals of each type. Doesn't need to be in this PR.

Wasmtime GitHub notifications bot (Oct 05 2026 at 21:51):

fitzgen added PR #14435 [gc_fuzz]: Clean up the source of gc_ops to the merge queue.

Wasmtime GitHub notifications bot (Oct 05 2026 at 22:33):

:memo: khagankhan submitted PR review.

Wasmtime GitHub notifications bot (Oct 05 2026 at 22:33):

:speech_balloon: khagankhan created PR review comment:

I agree. I have done the Places paradigm on local we need n "boxes" for each type anyway

Wasmtime GitHub notifications bot (Oct 05 2026 at 23:03):

:check: fitzgen merged PR #14435.

Wasmtime GitHub notifications bot (Oct 05 2026 at 23:03):

fitzgen removed PR #14435 [gc_fuzz]: Clean up the source of gc_ops from the merge queue.

Last updated: Oct 11 2026 at 04:10 UTC